Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 26956 invoked from network); 3 Jan 2007 00:19:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jan 2007 00:19:50 -0000 Received: (qmail 85118 invoked by uid 500); 3 Jan 2007 00:19:55 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 85053 invoked by uid 500); 3 Jan 2007 00:19:55 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 85042 invoked by uid 99); 3 Jan 2007 00:19:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 16:19:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 16:19:47 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 7ED5B7142FB for ; Tue, 2 Jan 2007 16:19:27 -0800 (PST) Message-ID: <1693926.1167783567501.JavaMail.jira@brutus> Date: Tue, 2 Jan 2007 16:19:27 -0800 (PST) From: "Ben Speakmon (JIRA)" To: commons-dev@jakarta.apache.org Subject: [jira] Updated: (EMAIL-35) [email] Embedding raw DataSource Attachments MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/EMAIL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated EMAIL-35: ------------------------------ Attachment: HtmlEmail.patch > [email] Embedding raw DataSource Attachments > -------------------------------------------- > > Key: EMAIL-35 > URL: https://issues.apache.org/jira/browse/EMAIL-35 > Project: Commons Email > Issue Type: Bug > Affects Versions: 1.0 > Environment: Operating System: All > Platform: All > Reporter: Brandon Wolfe > Attachments: EnhancedHtmlEmail.java, HtmlEmail.patch > > > I kick myself for not submitting this prior to 1.0. An important feature > missing from org.apache.commons.mail.HtmlEmail is the ability to embed an > arbitrary DataSource object. The current API only allows you to embed from a > URL. My usage of CommonsEmail often includes the generation of image data > on-the-fly, where it does not exist at a pre-defined URL. > I propose the addition of a key method: > public String embed(DataSource datasource, String name, String cid) throws > EmailException > This will allow us to attach our own datasources in addition to defining our own > content-ids. Helper methods can be created to auto-generate CIDs when needed > and allow for backwards compatability. I've found that being able to provide my > own defined CIDs has been very helpful in referencing them in my velocity email > templates. > I will attach the current EnhancedHtmlEmail class that I have been using for a > year or so. It extends HtmlEmail to provide the methods explained above. I > would hope to have this capability introduced into the HtmlEmail class. > Feel free to contact me to discuss further! Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org