commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nicolas de loof" <nicolas.del...@gmail.com>
Subject Re: REPOST [attributes 2.2] Missing optional package Extension
Date Tue, 16 Jan 2007 08:29:28 GMT
Can anyone make a release to solve this ?

2007/1/5, nicolas de loof <nicolas.deloof@gmail.com>:
>
>
> The manifest.mf in SVN contain a "Created-By: Apache Maven" but I never
> got maven include such "Extension-List" in my manifest. The one generated by
> the maven build don't include them. It seems the "
> maven.jar.manifest.extensions.add" option creates those entries in
> manifest. Maybe this property was set on the debian box used to build
> attributes 2.2 ?
>
> From maven jar plugin doc :
> "
> maven.jar.manifest.extensions.add      : Tells Maven to add extension
> information to the jar manifest. This can cause some applications to break,
> so it has been disabled by default. An Implementation-Vendor-Id attribute
> will be added for each dependency that has a <vendorId> element set in its
> <properties> section. Set to true to enable extension information.
> "
> Seems using such extension is not recommended...
>
>
> I've used maven (not ant) to build on Windows. I can't test on a Mac.
>
> I've checked for 1.4 methods by importing api/compiler/unittest into
> eclipse and setting JRE to 1.3 : There is no compile requirement for Java
> 1.4
> Maybe those compiler options have been set to allow compilation under
> Java5 JDK.
>
> The ant build.xml contains source="1.4" target="1.4" for the Javac task.
> I've trie building with source="1.3" target="1.3" and it passed
>
> Nico.
>
> 2007/1/4, Henri Yandell <flamefew@gmail.com >:
> >
> > On 1/4/07, nicolas de loof <nicolas.deloof@gmail.com > wrote:
> > > According to SVN log, the manifest has been added by "bayard". The
> > maven
> > > generated manifest is not used (why ?)
> >
> > These are for the Ant build - they're the ones that Maven generated
> > for me. Seem to recall that attributes didn't like building on the
> > Mac, so this was done on a Debian Linux box with Sun 1.4.2 and Maven
> > 1.0.2.
> >
> > Unless manifest.mf is a name convention; they're not used for the Maven
> > build.
> >
> > > I also notice maven.compiler.target has been set to 1.4 during 2.2(rev
> > > 410143 by leosutic) that will break backward compatibility : I'm using
> > > commons-attributes on other projects on JRE 1.3 .
> > >
> > > I've tested some changes from commons-attributes trunk :
> > >
> > > change maven.compiler.source and maven.compiler.target to 1.3 in
> > > project.properties
> >
> > Does it compile under 1.3 for you (using Ant I presume)? I'm wondering
> > why the move to 1.4 was done, maybe there's a call to a 1.4 only
> > method in there somewhere.
> >
> > > remove manifest.mf from "api" sub-project
> >
> > Should be unnecessary.
> >
> > > remove dependencies in api/project.xml (as they are only required by
> > > compiler)
> >
> > +1.
> >
> > > With those changes, my webapp launch fine and run as expected.
> > >
> > > From what I've read, Extension-List is used to allow downloading of
> > libs at
> > > runtime when not available in classpath. As ant and qdox manifest
> > don't
> > > declare themself as extensions, the extension resolution fails.
> > >
> > > I'd suggest a new release as compatibility with 1.3 is blocking for me
> > to
> > > upgrade.
> >
> > Sounds good - once we grok why it was moved to 1.4.
> >
> > Hen
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message