commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COLLECTIONS-239) In LinkIterator hasPrevious() is not working properly for the first entry
Date Mon, 29 Jan 2007 23:18:49 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468439
] 

Henri Yandell commented on COLLECTIONS-239:
-------------------------------------------

Looking at trunk, the actual code is:

            return (next.before != parent.header);

Not the most semantically clear, but the following test appears to pass quite happily:

    // http://issues.apache.org/jira/browse/COLLECTIONS-239
    public void testCollections239() {
        LinkedMap map = new LinkedMap();
        map.put("1", "1");
        map.put("2", "2");
        map.put("3", "3");
        map.put("4", "4");

        OrderedIterator itr = (OrderedIterator) map.values().iterator();
        assertFalse( itr.hasPrevious() );
        for( int i=0; i < 4; i++) {
            assertTrue( itr.hasNext() );
            Object ignore = itr.next();
            assertTrue( itr.hasPrevious() );
        }

        assertFalse( itr.hasNext() );
    }

So I think this is resolvable as "cannot reproduce". Do you have a test case that fails?

> In LinkIterator hasPrevious() is not working properly for the first entry
> -------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-239
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-239
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Iterator
>    Affects Versions: 3.2
>         Environment: Windows XP, jdk-1.5.0_02
>            Reporter: Michael Pavlov
>
> In hasPrevious() method of LinkIterator 'next' field is used, that is not correct  -
method returns 'true' for the first entry. 'last' field should be used insted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message