commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mario Ivankovits (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SANDBOX-183) Compress should allow for writing to Zip Files
Date Thu, 04 Jan 2007 07:39:27 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462159
] 

Mario Ivankovits commented on SANDBOX-183:
------------------------------------------

I haven't had the time to give it a try, but looks promising.

Just a few things in advance:

* use the org.apache.commons.compress package prefix (instead of the com.* one)
* add the ASF license header
* use method names with lower-case first letter
* did you already sent a CLA? [1]
* do not use e.printStrackTrace()

Then something technically
* ModifiableZipFile.WriteExistingEntries: when you "shift" the content you allocate a buffer
with the full sizeOfBlock size, isn't it dangerous (out of memeory) when you have to deal
with large zip files, or at least with a large compressed entry?

Thanks!
Mario

[1] http://www.apache.org/licenses/#clas

> Compress should allow for writing to Zip Files
> ----------------------------------------------
>
>                 Key: SANDBOX-183
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-183
>             Project: Commons Sandbox
>          Issue Type: New Feature
>          Components: Compress
>    Affects Versions: Nightly Builds
>            Reporter: Will Pugh
>             Fix For: Nightly Builds
>
>         Attachments: myzip.zip
>
>
> Compress should be able to modify existing ZipFiles.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message