commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Ewins (JIRA)" <j...@apache.org>
Subject [jira] Created: (BEANUTILS-266) Log or throw exception in PropertyUtilsBean, not both
Date Mon, 04 Dec 2006 11:37:22 GMT
Log or throw exception in PropertyUtilsBean, not both
-----------------------------------------------------

                 Key: BEANUTILS-266
                 URL: http://issues.apache.org/jira/browse/BEANUTILS-266
             Project: Commons BeanUtils
          Issue Type: Improvement
          Components: Bean / Property Utils
    Affects Versions: 1.7.0
         Environment: all
            Reporter: Brian Ewins


This commit (related to BEANUTILS-224):
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java?view=diff&r1=471989&r2=471990

improved the error message for illegal arguments, but also introduced a log message for that
same exception. Best practice is to log or throw but not both, since this often results in
the error being logged multiple times - when it was created and when the exception is caught.
In addition this is logging the problem as an error when it may in fact be handled by the
caller, so at worst its a debug-level message.

I switched up to 1.7 recently and this has been filling up my logs. I know I can work around
it by disabling logging for this component but the existence of this log message seems like
an oversight.




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message