commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Heger <oliver.he...@oliver-heger.de>
Subject Re: svn commit: r489734 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
Date Mon, 25 Dec 2006 17:25:20 GMT
Hm, there are two valueOf() methods, one expecting a String and one that
takes a boolean as argument. In this case the latter one is needed. But
according to the API doc for J2SE 6 [1] the since tag says 1.4.

Oliver

[1]
http://java.sun.com/javase/6/docs/api/java/lang/Boolean.html#valueOf(boolean)

Henri Yandell wrote:
> Looks like it was there in 1.3:
> 
> http://java.sun.com/j2se/1.3/docs/api/java/lang/Boolean.html#valueOf(java.lang.String)
> 
> 
> However there's a bug in JDK 1.2 (so it was there in 1.2, but not very
> good).
> 
> http://mail-archives.apache.org/mod_mbox/jakarta-commons-dev/200601.mbox/%3C1137744422.4693.154.camel@localhost.localdomain%3E
> 
> 
> So that might be an issue. Cooking christmas breakfast atm, so will
> look later (we're doing it a couple of days earlier to take advantage
> of the weekend :) ).
> 
> Hen
> 
> On 12/23/06, Oliver.Heger <oliver.heger@oliver-heger.de> wrote:
> 
>> AFAIK the Boolean.valueOf(boolean) method is available since JDK 1.4
>> only. I think [lang] is intended to support earlier JDKs, too.
>>
>> Oliver
>>
>> bayard@apache.org wrote:
>> > Author: bayard
>> > Date: Fri Dec 22 11:31:28 2006
>> > New Revision: 489734
>> >
>> > URL: http://svn.apache.org/viewvc?view=rev&rev=489734
>> > Log:
>> > new Boolean -> Boolean.valueOf. (Reported by FindBugs)
>> >
>> > Modified:
>> >    
>> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
>>
>> >
>> > Modified:
>> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
>>
>> > URL:
>> http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java?view=diff&rev=489734&r1=489733&r2=489734
>>
>> >
>> ==============================================================================
>>
>> > ---
>> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
>> (original)
>> > +++
>> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
>> Fri Dec 22 11:31:28 2006
>> > @@ -121,7 +121,7 @@
>> >       * @return the value as a Boolean
>> >       */
>> >      public Object getValue() {
>> > -        return new Boolean(this.value);
>> > +        return Boolean.valueOf(this.value);
>> >      }
>> >
>> >      /**
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message