commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nia...@apache.org
Subject svn commit: r488896 - in /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit: CheckDigit.java EAN13CheckDigit.java ISBN10CheckDigit.java ISBNCheckDigit.java LuhnCheckDigit.java VerhoeffCheckDigit.java
Date Wed, 20 Dec 2006 03:01:07 GMT
Author: niallp
Date: Tue Dec 19 19:01:06 2006
New Revision: 488896

URL: http://svn.apache.org/viewvc?view=rev&rev=488896
Log:
Make Verhoeff check digit final and JavaDoc changes

Modified:
    jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java
    jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java
    jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java
    jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java
    jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java
    jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/VerhoeffCheckDigit.java

Modified: jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java?view=diff&rev=488896&r1=488895&r2=488896
==============================================================================
--- jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java
(original)
+++ jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java
Tue Dec 19 19:01:06 2006
@@ -33,22 +33,15 @@
  * of this feature by providing the facility to validate ISBN-10 codes
  * and then convert them to the new ISBN-13 standard.
  * <p>
+ * {@link CheckDigit} is used by the new generic
+ * <a href="..\CodeValidator.html">CodeValidator</a> implementation.
+ * <p>
  * <h3>Implementations</h3>
- * The following check digit implementations are provided as standard:
- * <ul>
- *   <li>{@link ModulusCheckDigit} - an abstract class which provides the logic
- *       for <i>modulus</i> check digit calculation/validation.</li>
- *   <li>{@link EAN13CheckDigit} - check digit calculation/validation for
- *       numeric EAN codes (based on the standard EAN-13).</li>
- *   <li>{@link ISBN10CheckDigit} - check digit calculation/validation for
- *       numeric ISBN-10 codes (the new ISBN-13 code is actually an EAN-13
- *       code and uses the same check digit calculation).</li>
- *   <li>{@link ISBNCheckDigit} - check digit calculation/validation for
- *       both ISBN-10 and ISBN-13 codes.</li>
- *   <li>{@link LuhnCheckDigit} - Luhn check digit calculation/validation
- *       commonly used by credit card numbers.</li>
- * </ul>
+ * See the 
+ * <a href="package-summary.html">Package Summary</a> for a full
+ * list of implementations provided within Commons Validator.
  *
+ * @see org.apache.commons.validator.routines.CodeValidator
  * @version $Revision$ $Date$
  * @since Validator 1.4
  */

Modified: jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java?view=diff&rev=488896&r1=488895&r2=488896
==============================================================================
--- jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java
(original)
+++ jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java
Tue Dec 19 19:01:06 2006
@@ -44,7 +44,7 @@
  */
 public final class EAN13CheckDigit extends ModulusCheckDigit implements Serializable {
 
-    /** Static EAN-13 Check Digit instance */
+    /** Singleton EAN-13 Check Digit instance */
     public static final CheckDigit INSTANCE = new EAN13CheckDigit();
 
     /** weighting given to digits depending on their right position */

Modified: jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java?view=diff&rev=488896&r1=488895&r2=488896
==============================================================================
--- jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java
(original)
+++ jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java
Tue Dec 19 19:01:06 2006
@@ -46,7 +46,7 @@
  */
 public final class ISBN10CheckDigit extends ModulusCheckDigit implements Serializable {
 
-    /** Static ISBN-10 check digit instance */
+    /** Singleton ISBN-10 Check Digit instance */
     public static final CheckDigit INSTANCE = new ISBN10CheckDigit();
 
     /**

Modified: jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java?view=diff&rev=488896&r1=488895&r2=488896
==============================================================================
--- jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java
(original)
+++ jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java
Tue Dec 19 19:01:06 2006
@@ -36,13 +36,13 @@
  */
 public final class ISBNCheckDigit implements CheckDigit, Serializable {
 
-    /** Static ISBN-10 check digit instance */
+    /** Singleton ISBN-10 Check Digit instance */
     public static final CheckDigit ISBN10 = ISBN10CheckDigit.INSTANCE;
 
-    /** Static ISBN-13 Check Digit instance */
+    /** Singleton ISBN-13 Check Digit instance */
     public static final CheckDigit ISBN13 = EAN13CheckDigit.INSTANCE;
 
-    /** Combined static ISBN-10/ISBN-13 check digit instance */
+    /** Singleton combined ISBN-10 / ISBN-13 Check Digit instance */
     public static final CheckDigit ISBN   = new ISBNCheckDigit();
 
     /**

Modified: jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java?view=diff&rev=488896&r1=488895&r2=488896
==============================================================================
--- jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java
(original)
+++ jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java
Tue Dec 19 19:01:06 2006
@@ -40,7 +40,7 @@
  */
 public final class LuhnCheckDigit extends ModulusCheckDigit implements Serializable {
 
-    /** Static Luhn Check Digit instance */
+    /** Singleton Luhn Check Digit instance */
     public static final CheckDigit INSTANCE = new LuhnCheckDigit();
 
     /** weighting given to digits depending on their right position */

Modified: jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/VerhoeffCheckDigit.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/VerhoeffCheckDigit.java?view=diff&rev=488896&r1=488895&r2=488896
==============================================================================
--- jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/VerhoeffCheckDigit.java
(original)
+++ jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/VerhoeffCheckDigit.java
Tue Dec 19 19:01:06 2006
@@ -31,9 +31,9 @@
  * @version $Revision$ $Date$
  * @since Validator 1.4
  */
-public class VerhoeffCheckDigit implements CheckDigit, Serializable {
+public final class VerhoeffCheckDigit implements CheckDigit, Serializable {
 
-    /** Static Verhoeff check digit instance */
+    /** Singleton Verhoeff Check Digit instance */
     public static final CheckDigit INSTANCE = new VerhoeffCheckDigit();
 
     /** D - multiplication table */



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message