Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 14816 invoked from network); 18 Nov 2006 12:45:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Nov 2006 12:45:07 -0000 Received: (qmail 39844 invoked by uid 500); 18 Nov 2006 12:45:15 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 39678 invoked by uid 500); 18 Nov 2006 12:45:13 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 39667 invoked by uid 99); 18 Nov 2006 12:45:13 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Nov 2006 04:45:13 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Nov 2006 04:45:01 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 56969714310 for ; Sat, 18 Nov 2006 04:44:41 -0800 (PST) Message-ID: <9194793.1163853881351.JavaMail.jira@brutus> Date: Sat, 18 Nov 2006 04:44:41 -0800 (PST) From: "Dennis Lundberg (JIRA)" To: commons-dev@jakarta.apache.org Subject: [jira] Resolved: (LOGGING-9) [logging] Log.trace() doesn't use log4j 1.3 trace methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/LOGGING-9?page=all ] Dennis Lundberg resolved LOGGING-9. ----------------------------------- Resolution: Fixed > [logging] Log.trace() doesn't use log4j 1.3 trace methods > --------------------------------------------------------- > > Key: LOGGING-9 > URL: http://issues.apache.org/jira/browse/LOGGING-9 > Project: Commons Logging > Issue Type: Bug > Affects Versions: 1.0.4 > Environment: Operating System: other > Platform: Other > Reporter: Peter DeGregorio > Fix For: 1.1.0 > > > Jakarta Commons Logging 1.0.4 detects log4j 1.3 and alters its behaviour > accordingly but continues to map its trace methods to log4j debug methods > while log4j 1.3 now has its own trace methods. The following patch fixes this > bug: > Index: commons- > logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java > =================================================================== > --- commons-logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java > (revision 161137) > +++ commons-logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java > (working copy) > @@ -84,7 +84,7 @@ > if(is12) { > getLogger().log(FQCN, (Priority) Level.DEBUG, message, null ); > } else { > - getLogger().log(FQCN, Level.DEBUG, message, null ); > + getLogger().log(FQCN, Level.TRACE, message, null ); > } > } > > @@ -97,7 +97,7 @@ > if(is12) { > getLogger().log(FQCN, (Priority) Level.DEBUG, message, t ); > } else { > - getLogger().log(FQCN, Level.DEBUG, message, t ); > + getLogger().log(FQCN, Level.TRACE, message, t ); > } > } > > @@ -277,7 +277,11 @@ > * For Log4J, this returns the value of isDebugEnabled() > */ > public boolean isTraceEnabled() { > - return getLogger().isDebugEnabled(); > + if(is12) { > + return getLogger().isDebugEnabled(); > + } else { > + return getLogger().isTraceEnabled(); > + } > } > > /** -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org