Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 6985 invoked from network); 14 Nov 2006 23:46:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Nov 2006 23:46:04 -0000 Received: (qmail 81552 invoked by uid 500); 14 Nov 2006 23:46:12 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 81484 invoked by uid 500); 14 Nov 2006 23:46:12 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 81473 invoked by uid 500); 14 Nov 2006 23:46:12 -0000 Received: (qmail 81470 invoked by uid 99); 14 Nov 2006 23:46:12 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2006 15:46:12 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2006 15:46:01 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id 474311A984D; Tue, 14 Nov 2006 15:45:31 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r475060 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DateTimeConverter.java Date: Tue, 14 Nov 2006 23:45:31 -0000 To: commons-cvs@jakarta.apache.org From: bayard@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20061114234531.474311A984D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bayard Date: Tue Nov 14 15:45:30 2006 New Revision: 475060 URL: http://svn.apache.org/viewvc?view=rev&rev=475060 Log: Adding a bit more data to the conversion error messages Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DateTimeConverter.java Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DateTimeConverter.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DateTimeConverter.java?view=diff&rev=475060&r1=475059&r2=475060 ============================================================================== --- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DateTimeConverter.java (original) +++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DateTimeConverter.java Tue Nov 14 15:45:30 2006 @@ -399,7 +399,7 @@ return java.sql.Date.valueOf(value); } catch (IllegalArgumentException e) { throw new ConversionException( - "Date must be in JDBC format [yyyy-MM-dd]"); + "String must be in JDBC format [yyyy-MM-dd] to create a java.sql.Date"); } } @@ -409,7 +409,7 @@ return java.sql.Time.valueOf(value); } catch (IllegalArgumentException e) { throw new ConversionException( - "Time must be in JDBC format [HH:mm:ss]"); + "String must be in JDBC format [HH:mm:ss] to create a java.sql.Time"); } } @@ -419,7 +419,8 @@ return java.sql.Timestamp.valueOf(value); } catch (IllegalArgumentException e) { throw new ConversionException( - "Timestamp must be in JDBC format [yyyy-MM-dd HH:mm:ss.fffffffff]"); + "String must be in JDBC format [yyyy-MM-dd HH:mm:ss.fffffffff] " + + "to create a java.sql.Timestamp"); } } @@ -489,7 +490,7 @@ } } if (patterns.length > 1) { - throw new ConversionException("Error converting to '" + toString(type) + throw new ConversionException("Error converting String to '" + toString(type) + "' using patterns '" + displayPatterns + "'"); } else { throw firstEx; @@ -512,7 +513,7 @@ ParsePosition pos = new ParsePosition(0); Date parsedDate = format.parse(value, pos); // ignore the result (use the Calendar) if (pos.getErrorIndex() >= 0 || pos.getIndex() != value.length() || parsedDate == null) { - String msg = "Error converting to '" + toString(type) + "'"; + String msg = "Error converting String to '" + toString(type) + "'"; if (format instanceof SimpleDateFormat) { msg += " using pattern '" + ((SimpleDateFormat)format).toPattern() + "'"; } --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org