commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy McArthur (JIRA)" <j...@apache.org>
Subject [jira] Commented: (POOL-93) Reduce contention by making borrow & return more independent from each other
Date Sat, 25 Nov 2006 00:41:03 GMT
    [ http://issues.apache.org/jira/browse/POOL-93?page=comments#action_12452542 ] 
            
Sandy McArthur commented on POOL-93:
------------------------------------

First look at the patch looks good.
Any reason not to replace direct access of _testOnReturn with calls to getTestOnReturn() ?
This would be thread-safe and allow newer HotSpot versions do the analysis to determine if
the synchronization of getTestOnReturn() is really needed. The problem with volatile is we
still need to support Java 1.4 and it wasn't until 1.5 JVMs that volatile was handled correctly
in all JVMs.

> Reduce contention by making borrow & return more independent from each other
> ----------------------------------------------------------------------------
>
>                 Key: POOL-93
>                 URL: http://issues.apache.org/jira/browse/POOL-93
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: Nightly Builds
>            Reporter: Holger Hoffstätte
>         Attachments: GKOP-relaxedSyncOnReturn.patch, relaxedReturnObjectBenchmark.txt
>
>
> Currently borrow & return are completely blocked from each other, while at least
the factory-based validation & destruction can be handled independently. A few simple
changes narrow the synchronization blocks yet retain overall correctness.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message