commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Lundberg (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (LOGGING-9) [logging] Log.trace() doesn't use log4j 1.3 trace methods
Date Sat, 18 Nov 2006 12:44:41 GMT
     [ http://issues.apache.org/jira/browse/LOGGING-9?page=all ]

Dennis Lundberg resolved LOGGING-9.
-----------------------------------

    Resolution: Fixed

> [logging] Log.trace() doesn't use log4j 1.3 trace methods
> ---------------------------------------------------------
>
>                 Key: LOGGING-9
>                 URL: http://issues.apache.org/jira/browse/LOGGING-9
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.0.4
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Peter DeGregorio
>             Fix For: 1.1.0
>
>
> Jakarta Commons Logging 1.0.4 detects log4j 1.3 and alters its behaviour 
> accordingly but continues to map its trace methods to log4j debug methods 
> while log4j 1.3 now has its own trace methods. The following patch fixes this 
> bug: 
> Index: commons-
> logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java
> ===================================================================
> --- commons-logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java
> 	(revision 161137)
> +++ commons-logging/src/java/org/apache/commons/logging/impl/Log4JLogger.java
> 	(working copy)
> @@ -84,7 +84,7 @@
>          if(is12) {
>              getLogger().log(FQCN, (Priority) Level.DEBUG, message, null );
>          } else {
> -            getLogger().log(FQCN, Level.DEBUG, message, null );
> +            getLogger().log(FQCN, Level.TRACE, message, null );
>          }
>      }
>  
> @@ -97,7 +97,7 @@
>          if(is12) {
>              getLogger().log(FQCN, (Priority) Level.DEBUG, message, t );
>          } else {
> -            getLogger().log(FQCN, Level.DEBUG, message, t );
> +            getLogger().log(FQCN, Level.TRACE, message, t );
>          }
>      }
>  
> @@ -277,7 +277,11 @@
>       * For Log4J, this returns the value of <code>isDebugEnabled()</code>
>       */
>      public boolean isTraceEnabled() {
> -        return getLogger().isDebugEnabled();
> +        if(is12) {
> +            return getLogger().isDebugEnabled();
> +        } else {
> +            return getLogger().isTraceEnabled();
> +        }
>      }
>  
>      /**

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message