commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz" <phil.ste...@gmail.com>
Subject Re: [betwixt] please check RC1
Date Sun, 12 Nov 2006 19:37:38 GMT
On 11/12/06, robert burrell donkin <robertburrelldonkin@blueyonder.co.uk> wrote:
> everyone ok with the current codebase?
>
Sorry for the late response.  I am not familiar with the code base, so
comments below are just mechanical.  Both maven and ant builds worked
fine for me on FC 3, with Sun 1.5_06 jdk.  Some small comments:

1. The release notes are great.  They would be even greater if you
replaced the old bugzilla issue numbers with the JIRA references :-).
There is also a reference at the top to the "change log document"
which I would expect to be the maven changelog report, but that report
is excluded from the site.

2. I would delete the last line of project.properties.  If this is
actually used for anything, we are in trouble ;-)

3.  What is conf/MANIFEST.MF for?  It is not what gets put into the
jar (which looks fine)

4. Do you really mean X-Compile-Target-JDK: 1.1?

5. For general education purposes, should we *all* now be adding
copyright statements to NOTICE.txt as you did?   We should probably do
this across the board in SVN.

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message