commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (BEANUTILS-41) [beanutils] Provide better error message for "No value specified"
Date Tue, 14 Nov 2006 23:41:38 GMT
    [ http://issues.apache.org/jira/browse/BEANUTILS-41?page=comments#action_12449862 ] 
            
Henri Yandell commented on BEANUTILS-41:
----------------------------------------


1) -1 to the API change. I think it would be better for the copyProperties method to catch
the ConversionException and then log.error something with more context and throw a BeanUtilsCopyException
that wraps it.

2) This code has been overhauled and the new code (DateTimeConverter) seems to do a better
job about mentioning the types it is trying for (I've added a bit more).

3) I think this would overload the error.

----

So in terms of work needing to be done; I think there should be code where Converters are
called that catch ConversionExceptions and apply knowledge about the bean specific context.



> [beanutils] Provide better error message for "No value specified"
> -----------------------------------------------------------------
>
>                 Key: BEANUTILS-41
>                 URL: http://issues.apache.org/jira/browse/BEANUTILS-41
>             Project: Commons BeanUtils
>          Issue Type: Bug
>          Components: ConvertUtils & Converters
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Ralf Hauser
>             Fix For: 1.8.0
>
>
> Got <<org.apache.commons.beanutils.ConversionException: No value specified
>         at
> org.apache.commons.beanutils.converters.SqlDateConverter.convert(SqlDateConverter.java:103)
>         at
> org.apache.commons.beanutils.BeanUtilsBean.copyProperty(BeanUtilsBean.java:444)
>         at
> org.apache.commons.beanutils.BeanUtilsBean.copyProperties(BeanUtilsBean.java:261)
>         at
> org.apache.commons.beanutils.BeanUtils.copyProperties(BeanUtils.java:114)>>
>  
> Suggestion:
> 1) cite the propName and the bean className
>    this probably implies that the interface
>      org.apache.commons.beanutils.Converter.convert(Class type, Object value)
>    is extended to 
>      org.apache.commons.beanutils.Converter.convert(Class type, Object value,
>                                         String propName, String beanClassName)
> 2) also cite the concerned class name (probably java.sql.Date) 
> 3) mention that there is the possibility to use a default value

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message