commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Breuer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (VALIDATOR-207) Disabled fields should not be checked by the validateRequired function. Relevant to adding the check for field disabled in jcv_isFieldPresent.
Date Thu, 16 Nov 2006 14:07:38 GMT
    [ http://issues.apache.org/jira/browse/VALIDATOR-207?page=comments#action_12450405 ] 
            
Joseph Breuer commented on VALIDATOR-207:
-----------------------------------------

The only reason why I submitted this as a bug is that the previous version of validator would
not check disabled fields for the required validation.  During an upgrade to the most recent
version of the validator an existing form that worked correctly before now would not make
it past validation even though the hidden input field was marked disabled.  We had to implement
a work around, dropping the disabled attribute and putting in a dummy value to validate correctly.

According to the documentation for the validateRequired fields are not checked if they are
disabled.
    /*$RCSfile: validateRequired.js $ $Rev: 376673 $ $Date: 2006/11/08 10:31:38EST $ */
    /**
    *  Check to see if fields must contain a value.
    * Fields are not checked if they are disabled.
    * <p>
    * @param form The form validation is taking place on.
    */

That functionality was particularly useful in our case because we could reuse a form and the
validation for the form for both the create and update functionality of an object.  However
for the update function we did not want the password to change so during the form creation
we conditionally create the input field and make it disabled and hidden for updates.

It seems that for backwards compatibility and for consistency across the validate methods
disabled fields should not be checked.

> Disabled fields should not be checked by the validateRequired function.  Relevant to
adding the check for field disabled in jcv_isFieldPresent.
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: VALIDATOR-207
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-207
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: JavaScript
>    Affects Versions: 1.3.0 Release
>            Reporter: Joseph Breuer
>
> For validateRequired the following condition checks to see if the field is present. 
It then sets the validity to false.
>             if (!jcv_isFieldPresent(field)) {
>                 fields[i++] = oRequired[x][1];
>                 isValid=false;
>             }
> Supposedly validateRequired as well as all of the validate methods are not supposed to
validate fields that are set as disabled.  This method seems to categorize disabled fields
with those that are null or are undefined.
> validateRequired should differentiate between the disabled fields and the not present
fields.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message