Return-Path: 
 <commons-dev-return-93303-apmail-jakarta-commons-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org
Received: (qmail 39039 invoked from network); 6 Sep 2006 01:59:56 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 6 Sep 2006 01:59:56 -0000
Received: (qmail 24372 invoked by uid 500); 6 Sep 2006 01:59:54 -0000
Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org
Received: (qmail 24307 invoked by uid 500); 6 Sep 2006 01:59:54 -0000
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:commons-dev-unsubscribe@jakarta.apache.org>
List-Help: <mailto:commons-dev-help@jakarta.apache.org>
List-Post: <mailto:commons-dev@jakarta.apache.org>
List-Id: "Jakarta Commons Developers List" <commons-dev.jakarta.apache.org>
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 24296 invoked by uid 99); 6 Sep 2006 01:59:54 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2006 18:59:54 -0700
X-ASF-Spam-Status: No, hits=0.5 required=10.0
	tests=DNS_FROM_RFC_ABUSE,HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of mfncooper@gmail.com designates
 64.233.184.226 as permitted sender)
Received: from [64.233.184.226] (HELO wr-out-0506.google.com) (64.233.184.226)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2006 18:59:53 -0700
Received: by wr-out-0506.google.com with SMTP id i11so418141wra
        for <commons-dev@jakarta.apache.org>;
 Tue, 05 Sep 2006 18:59:32 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:references:x-google-sender-auth;
        b=ijISVZg4uvbOU4Ly4iw7xj3+YW3Mr+/0E3qFZEz5OcDNsT4AC8E1V+SLlsGHBgbCsMTku3HU4yvl3UoTJBArl65021SFftU3qzs9ZAOW0Q5kuWP2Ol8ETg0WVpBBTgoVQp2+24XbK6+4hvbIHYyZLDHEO2Bi2cjB9HjiPVZQKr0=
Received: by 10.90.25.7 with SMTP id 7mr323424agy;
        Tue, 05 Sep 2006 18:59:32 -0700 (PDT)
Received: by 10.90.78.6 with HTTP; Tue, 5 Sep 2006 18:59:31 -0700 (PDT)
Message-ID: <16d6c6200609051859w72d5c3a4v9fe00364cab04a67@mail.gmail.com>
Date: Tue, 5 Sep 2006 18:59:31 -0700
From: "Martin Cooper" <martinc@apache.org>
Sender: mfncooper@gmail.com
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Subject: Re: svn commit: r439789 - in
 /jakarta/commons/proper/fileupload/trunk: ./ src/checkstyle/
 src/main/assembly/
In-Reply-To: <20060903152041.AEB1C1A981A@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_42364_20777252.1157507971941"
References: <20060903152041.AEB1C1A981A@eris.apache.org>
X-Google-Sender-Auth: c71b8a7b3e6573af
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

------=_Part_42364_20777252.1157507971941
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 9/3/06, jochen@apache.org <jochen@apache.org> wrote:
>
> Author: jochen
> Date: Sun Sep  3 08:20:39 2006
> New Revision: 439789
>
> URL: http://svn.apache.org/viewvc?rev=439789&view=rev
> Log:
> Moved the checkstyle and PMD files to src/checkstyle.


Storing PMD configuration in a 'checkstyle' directory doesn't make much
sense. If we want to store both in the same directory, how about calling
that directory just 'checks' or 'code-checks'?

--
Martin Cooper


Added:
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_basic.xml
> (props changed)
>       - copied unchanged from r429099,
> jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
> (contents, props changed)
>       - copied, changed from r439479,
> jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-
> header.txt   (contents, props changed)
>       - copied, changed from r429099,
> jakarta/commons/proper/fileupload/trunk/license-header.txt
> Removed:
>     jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml
>     jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
>     jakarta/commons/proper/fileupload/trunk/license-header.txt
> Modified:
>     jakarta/commons/proper/fileupload/trunk/pom.xml
>     jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml
>
> Modified: jakarta/commons/proper/fileupload/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/pom.xml?rev=439789&r1=439788&r2=439789&view=diff
>
> ==============================================================================
> --- jakarta/commons/proper/fileupload/trunk/pom.xml (original)
> +++ jakarta/commons/proper/fileupload/trunk/pom.xml Sun Sep  3 08:20:39
> 2006
> @@ -177,7 +177,7 @@
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-checkstyle-plugin</artifactId>
>          <configuration>
> -          <configLocation>fileupload_checks.xml</configLocation>
>
> +          <configLocation>src/checkstyle/fileupload_checks.xml</configLocation>
>          </configuration>
>        </plugin>
>        <plugin>
> @@ -204,6 +204,11 @@
>        <plugin>
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-pmd-plugin</artifactId>
> +        <configuration>
> +          <rulesets>
> +            <ruleset>src/checkstyle/fileupload_basic.xml</ruleset>
> +          </rulesets>
> +        </configuration>
>        </plugin>
>      </plugins>
>    </reporting>
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_basic.xml
>
> ------------------------------------------------------------------------------
>     svn:keywords = Date Author Id Revision HeadURL
>
> Copied:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
> (from r439479,
> jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml)
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml?p2=jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml&p1=jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml&r1=439479&r2=439789&rev=439789&view=diff
>
> ==============================================================================
> --- jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
> (original)
> +++
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
> Sun Sep  3 08:20:39 2006
> @@ -123,7 +123,7 @@
>          <!-- Following interprets the header file as regular expressions.
> -->
>          <!-- <module
> name="RegexpHeader"/>                                -->
>          <module name="RegexpHeader">
> -            <property name="headerFile" value="license-header.txt"/>
> +            <property name="headerFile" value="src/checkstyle/license-
> header.txt"/>
>          </module>
>
>
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
>
> ------------------------------------------------------------------------------
>     svn:keywords = Date Author Id Revision HeadURL
>
> Copied: jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-
> header.txt (from r429099, jakarta/commons/proper/fileupload/trunk/license-
> header.txt)
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt?p2=jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt&p1=jakarta/commons/proper/fileupload/trunk/license-header.txt&r1=429099&r2=439789&rev=439789&view=diff
>
> ==============================================================================
>     (empty)
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt
>
> ------------------------------------------------------------------------------
>     svn:keywords = Date Author Id Revision HeadURL
>
> Modified:
> jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml?rev=439789&r1=439788&r2=439789&view=diff
>
> ==============================================================================
> --- jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml
> (original)
> +++ jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml Sun
> Sep  3 08:20:39 2006
> @@ -9,19 +9,13 @@
>                 <include>build-gump.xml</include>
>                 <include>build.xml</include>
>                 <include>doap_fileupload.rdf</include>
> -               <include>fileupload_basic.xml</include>
> -               <include>fileupload_checks.xml</include>
>                 <include>gump.xml</include>
> -               <include>license-header.txt</include>
>                 <include>LICENSE.txt</include>
>          <include>maven.xml</include>
>          <include>NOTICE.txt</include>
>          <include>pom.xml</include>
>          <include>project.properties</include>
>          <include>project.xml</include>
> -        <include>PROPOSAL.html</include>
> -        <include>RELEASE-NOTES.txt</include>
> -        <include>STATUS.html</include>
>        </includes>
>      </fileSet>
>      <fileSet>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>

------=_Part_42364_20777252.1157507971941--