commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dion Gillard" <dion.gill...@gmail.com>
Subject Re: [VOTE] Release Commons JEXL 1.1
Date Tue, 05 Sep 2006 01:45:23 GMT
Rahul,

I'll start looking at the checkstyle config and issues if you're happy
with that?

On 9/4/06, Phil Steitz <phil.steitz@gmail.com> wrote:
> Looks good to me.  +1 assuming build has been tested on 1.2, which is
> what the jar manifest specifies.
>
> One small nit, which you could do without another RC, IMO, or ignore:
>
> The checkstyle report is not clean.  One real javadoc error is
> flagged, some missing javadoc, missing package javadoc for a couple of
> packages, and some bogus complaints. I would recommend either fixing
> all of the errors, modifying checkstyle.xml, or dropping the report
> from the doc included in the distribution.
>
> Phil
>
> On 8/31/06, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
> > Ran the usual gamut of checks, looks good to me.
> >
> > <snip/>
> > > ---------------
> > > [X] +1  I support this release
> > > [ ] +0
> > > [ ] -0
> > > [ ] -1  I oppose this release because...
> > > ----------------
> > >
> > <snap/>
> >
> > -Rahul
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>


-- 
http://www.multitask.com.au/people/dion/
Rule #91: Hear all, trust nothing.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message