commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Heger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CONFIGURATION-224) BaseConfiguration.getProperty() returns reference to intenal store collection object instead of a clone
Date Mon, 18 Sep 2006 20:51:06 GMT
    [ http://issues.apache.org/jira/browse/CONFIGURATION-224?page=comments#action_12435561
] 
            
Oliver Heger commented on CONFIGURATION-224:
--------------------------------------------

For the incompatibility of ConfigurationDynaBean with some of the Configuration classes I
have created a special ticket: CONFIGURATION-227 (I did some further testing and found out
that there are more problems than dealing with lists). This is mainly to have this somewhere
documented, I see no easy solution for this problem ATM.

Meanwhile the vote for the release of Configuration 1.3 has passed, so these issues can be
addressed later (which IMHO is no big problem, because the code in question exists since the
very first release; so there is no need to hurry).

Do you think that updating the documentation of the getProperty() method in the way outlined
above would be a good idea?

> BaseConfiguration.getProperty() returns reference to intenal store collection object
instead of a clone
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-224
>                 URL: http://issues.apache.org/jira/browse/CONFIGURATION-224
>             Project: Commons Configuration
>          Issue Type: Bug
>         Environment: 1.3RC2
>            Reporter: Gabriele Garuglieri
>            Priority: Minor
>         Attachments: list.patch
>
>
> When the property object is a List or an Array, BaseConfiguration.getProperty() returns
a reference to the object contained in the store.
> This means that changing that object, changes the content of the properties store without
an explicit setProperty() or addProperty(). 
> Also any change to the object in the store will change the object that the code has reference
to, but the user is not aware that the property has changed unless he has added a ConfigurationListener.
> Attached a patch to make the object returned by BaseConfiguration.getProperty() a clone
of store content, to avoid side effects when changing Collection properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message