commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Kitching (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIGESTER-107) Provide ability to capture namespace snapshots
Date Sat, 23 Sep 2006 15:44:23 GMT
    [ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437112 ] 
            
Simon Kitching commented on DIGESTER-107:
-----------------------------------------

This looks pretty good to me. The only question I have is whether the new members of the Digester
class should be private rather than protected. A protected member is effectively part of the
public contract for the class, which restricts our ability to modify implementations later;
I think I would personally prefer to see all the members made private, and only the new getCurrentNamespaces
method be public. The Digester class is currently a mix of both approaches, but the more recent
feature additions have used private members.

I wonder whether cloning the map is necessary. Instead, can member currentNamespaces simply
be an unmodifiable map, as a new instance is created if any namespace mappings change?

Cheers,

Simon

> Provide ability to capture namespace snapshots
> ----------------------------------------------
>
>                 Key: DIGESTER-107
>                 URL: http://issues.apache.org/jira/browse/DIGESTER-107
>             Project: Commons Digester
>          Issue Type: Improvement
>    Affects Versions: Nightly Builds
>            Reporter: Rahul Akolkar
>         Attachments: DIGESTER-107.patch
>
>
> Attached patch adds the capability to snapshot current namespaces at any point during
parsing. This is useful, for example, in Commons SCXML where the value of an attribute can
contain an XPath expression which needs to be evaluated later. The testcase in the patch captures
namespace snapshots for each object created by the digester. Feedback welcome.
> As an aside, does anyone mind if I bring the Digester JIRA versions up to date? Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message