commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Cooper" <mart...@apache.org>
Subject Re: svn commit: r439789 - in /jakarta/commons/proper/fileupload/trunk: ./ src/checkstyle/ src/main/assembly/
Date Wed, 06 Sep 2006 01:59:31 GMT
On 9/3/06, jochen@apache.org <jochen@apache.org> wrote:
>
> Author: jochen
> Date: Sun Sep  3 08:20:39 2006
> New Revision: 439789
>
> URL: http://svn.apache.org/viewvc?rev=439789&view=rev
> Log:
> Moved the checkstyle and PMD files to src/checkstyle.


Storing PMD configuration in a 'checkstyle' directory doesn't make much
sense. If we want to store both in the same directory, how about calling
that directory just 'checks' or 'code-checks'?

--
Martin Cooper


Added:
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_basic.xml
> (props changed)
>       - copied unchanged from r429099,
> jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
> (contents, props changed)
>       - copied, changed from r439479,
> jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
>     jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-
> header.txt   (contents, props changed)
>       - copied, changed from r429099,
> jakarta/commons/proper/fileupload/trunk/license-header.txt
> Removed:
>     jakarta/commons/proper/fileupload/trunk/fileupload_basic.xml
>     jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
>     jakarta/commons/proper/fileupload/trunk/license-header.txt
> Modified:
>     jakarta/commons/proper/fileupload/trunk/pom.xml
>     jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml
>
> Modified: jakarta/commons/proper/fileupload/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/pom.xml?rev=439789&r1=439788&r2=439789&view=diff
>
> ==============================================================================
> --- jakarta/commons/proper/fileupload/trunk/pom.xml (original)
> +++ jakarta/commons/proper/fileupload/trunk/pom.xml Sun Sep  3 08:20:39
> 2006
> @@ -177,7 +177,7 @@
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-checkstyle-plugin</artifactId>
>          <configuration>
> -          <configLocation>fileupload_checks.xml</configLocation>
>
> +          <configLocation>src/checkstyle/fileupload_checks.xml</configLocation>
>          </configuration>
>        </plugin>
>        <plugin>
> @@ -204,6 +204,11 @@
>        <plugin>
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-pmd-plugin</artifactId>
> +        <configuration>
> +          <rulesets>
> +            <ruleset>src/checkstyle/fileupload_basic.xml</ruleset>
> +          </rulesets>
> +        </configuration>
>        </plugin>
>      </plugins>
>    </reporting>
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_basic.xml
>
> ------------------------------------------------------------------------------
>     svn:keywords = Date Author Id Revision HeadURL
>
> Copied:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
> (from r439479,
> jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml)
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml?p2=jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml&p1=jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml&r1=439479&r2=439789&rev=439789&view=diff
>
> ==============================================================================
> --- jakarta/commons/proper/fileupload/trunk/fileupload_checks.xml
> (original)
> +++
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
> Sun Sep  3 08:20:39 2006
> @@ -123,7 +123,7 @@
>          <!-- Following interprets the header file as regular expressions.
> -->
>          <!-- <module
> name="RegexpHeader"/>                                -->
>          <module name="RegexpHeader">
> -            <property name="headerFile" value="license-header.txt"/>
> +            <property name="headerFile" value="src/checkstyle/license-
> header.txt"/>
>          </module>
>
>
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml
>
> ------------------------------------------------------------------------------
>     svn:keywords = Date Author Id Revision HeadURL
>
> Copied: jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-
> header.txt (from r429099, jakarta/commons/proper/fileupload/trunk/license-
> header.txt)
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt?p2=jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt&p1=jakarta/commons/proper/fileupload/trunk/license-header.txt&r1=429099&r2=439789&rev=439789&view=diff
>
> ==============================================================================
>     (empty)
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> jakarta/commons/proper/fileupload/trunk/src/checkstyle/license-header.txt
>
> ------------------------------------------------------------------------------
>     svn:keywords = Date Author Id Revision HeadURL
>
> Modified:
> jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml
> URL:
> http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml?rev=439789&r1=439788&r2=439789&view=diff
>
> ==============================================================================
> --- jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml
> (original)
> +++ jakarta/commons/proper/fileupload/trunk/src/main/assembly/src.xml Sun
> Sep  3 08:20:39 2006
> @@ -9,19 +9,13 @@
>                 <include>build-gump.xml</include>
>                 <include>build.xml</include>
>                 <include>doap_fileupload.rdf</include>
> -               <include>fileupload_basic.xml</include>
> -               <include>fileupload_checks.xml</include>
>                 <include>gump.xml</include>
> -               <include>license-header.txt</include>
>                 <include>LICENSE.txt</include>
>          <include>maven.xml</include>
>          <include>NOTICE.txt</include>
>          <include>pom.xml</include>
>          <include>project.properties</include>
>          <include>project.xml</include>
> -        <include>PROPOSAL.html</include>
> -        <include>RELEASE-NOTES.txt</include>
> -        <include>STATUS.html</include>
>        </includes>
>      </fileSet>
>      <fileSet>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message