commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriele Garuglieri (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CONFIGURATION-223) PropertiesConfigurationLayout broke the autoSave behaviour of PropertiesConfiguration
Date Tue, 29 Aug 2006 10:48:25 GMT
     [ http://issues.apache.org/jira/browse/CONFIGURATION-223?page=all ]

Gabriele Garuglieri updated CONFIGURATION-223:
----------------------------------------------

    Attachment: 223-test.patch

I guess it should work, but this would change the operations behaviour, making them more ore
less "atomic".
Understanding all the possible side effects of this change was too far from my actual knowledge
of all internal subtleties and i couldn't afford the time to develop a patch for this.

Anyway i attach a patch with some testcases you can use to verify the problem.

Regards,  Gabriele

PS: this broke all my JMX work on properties persistence... :(

> PropertiesConfigurationLayout broke the autoSave behaviour of PropertiesConfiguration
> -------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-223
>                 URL: http://issues.apache.org/jira/browse/CONFIGURATION-223
>             Project: Commons Configuration
>          Issue Type: Bug
>         Environment: 1.3RC1
>            Reporter: Gabriele Garuglieri
>         Assigned To: Oliver Heger
>            Priority: Critical
>         Attachments: 223-test.patch
>
>
> When using  PropertiesConfiguration with autoSave "true" the PropertiesConfigurationLayout
causes invalid properties files to be saved.
> When using addProperty("key", "value"); where key does not exist yet in the configuration
the EVENT_ADD_PROPERTY event that updates the PropertiesConfigurationLayout with the new "key"
is issued only after the possiblySave() method is invoked so the new property will not be
saved.
> When using setProperty("key", "value"); where key does not exist yet in the configuration
the EVENT_SET_PROPERTY event that updates the PropertiesConfigurationLayout with the new "key"
is issued only after the possiblySave() method is invoked so the new property will not be
saved.
> The way it is implemented now makes content of the saved file depending on PropertiesConfigurationLayout
content that depends on an event that will be issued only after the file was properly updated.
This creates a circular dependency that cannot work.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message