commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ortwin Glück (JIRA) <j...@apache.org>
Subject [jira] Commented: (SANDBOX-166) Improve memory use
Date Thu, 10 Aug 2006 13:26:20 GMT
    [ http://issues.apache.org/jira/browse/SANDBOX-166?page=comments#action_12427212 ] 
            
Ortwin Glück commented on SANDBOX-166:
--------------------------------------

As to "CharBuffer ... might be valuable for Lang":
If anyone wants it he may copy it over to Lang. Maybe the CharArrayBuffer / ByteArrayBuffer
from the HttpComponents projects is a better choice though.

What must not happen is, that CSV uses the CharBuffer class from Lang! This implementation
is as you said "at the heart of the system" and it is important that it fits the CSV needs
100%.  Especially the linear and minimalistic growing characteristics (as opposed to the exponential
growing of a StringBuffer) may not be what anyone else wants. So please keep this CSV local
copy, so it can be changed as needed.

> Improve memory use
> ------------------
>
>                 Key: SANDBOX-166
>                 URL: http://issues.apache.org/jira/browse/SANDBOX-166
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: CSV
>    Affects Versions: Nightly Builds
>            Reporter: Ortwin Glück
>         Assigned To: Ortwin Glück
>             Fix For: Nightly Builds
>
>         Attachments: optimized.png, patch.txt, profile.png
>
>
> The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP
profiler.  As you can see the parser creates around 100MB of garbage whereas it could (in
really optimized) use around 4MBs.  Such figures are not acceptable within a server environment.
Please attach insights and patches to this issue report.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message