commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell" <flame...@gmail.com>
Subject Re: svn commit: r432025 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Date Thu, 17 Aug 2006 03:58:36 GMT
On 8/16/06, Stephen Colebourne <scolebourne@btopenworld.com> wrote:
> Rahul Akolkar wrote:
> > On 8/16/06, ggregory@apache.org <ggregory@apache.org> wrote:
> >
> >> Author: ggregory
> >> Date: Wed Aug 16 13:36:35 2006
> >> New Revision: 432025
> >>
> >> URL: http://svn.apache.org/viewvc?rev=432025&view=rev
> >> Log:
> >> Access to enclosing constructors is emulated by a synthetic accessor
> >> methods. Increasing its visibility will improve your performance
> >> (Eclipse compiler).
> >>
> > <snip/>
> >
> > I've seen this discussion numerous times on various forums and often
> > it comes down to whether breaking the encapsulation is worth heeding
> > the synthetic accessor warning (a search should yield many related
> > results).
>
> I'm comfortable with the change, but it should go to default scope, not
> to protected scope. So I'm -0 to this particular checkin at present.

+1 to default scope.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message