commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r432024 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/exception/ExceptionUtilsTestCase.java
Date Wed, 16 Aug 2006 20:34:02 GMT
Author: ggregory
Date: Wed Aug 16 13:34:01 2006
New Revision: 432024

URL: http://svn.apache.org/viewvc?rev=432024&view=rev
Log:
Make sure this exception code does not depend on Java 1.4 nested exceptions. SVN revision
38990 does not compile with Java 1.3.1.
Compiled with Sun Java 1.3.1_15
Tested with Sun Java 1.3.1_15
Tested with Sun Java 1.4.2_12
Tested with Sun Java 1.5.0_08
All of the above on Windows XP SP2 + patches.

Modified:
    jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/exception/ExceptionUtilsTestCase.java

Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/exception/ExceptionUtilsTestCase.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/exception/ExceptionUtilsTestCase.java?rev=432024&r1=432023&r2=432024&view=diff
==============================================================================
--- jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/exception/ExceptionUtilsTestCase.java
(original)
+++ jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/exception/ExceptionUtilsTestCase.java
Wed Aug 16 13:34:01 2006
@@ -32,7 +32,23 @@
 
 /**
  * Tests {@link org.apache.commons.lang.exception.ExceptionUtils}.
- *
+ * 
+ * <h3>Notes</h3>
+ * <p>
+ * Make sure this exception code does not depend on Java 1.4 nested exceptions. SVN revision
38990 does not compile with
+ * Java 1.3.1.
+ * </p>
+ * <ul>
+ * <li>Compiled with Sun Java 1.3.1_15</li>
+ * <li>Tested with Sun Java 1.3.1_15</li>
+ * <li>Tested with Sun Java 1.4.2_12</li>
+ * <li>Tested with Sun Java 1.5.0_08</li>
+ * <li>All of the above on Windows XP SP2 + patches.</li>
+ * </ul>
+ * <p>
+ * Gary Gregory; August 16, 2006.
+ * </p>
+ * 
  * @author <a href="mailto:dlr@finemaltcoding.com">Daniel Rall</a>
  * @author <a href="mailto:steven@caswell.name">Steven Caswell</a>
  * @author Stephen Colebourne
@@ -46,7 +62,7 @@
     private Throwable withoutCause;
     private Throwable jdkNoCause;
     private ExceptionWithCause selfCause;
-    private ExceptionWithCause recursiveCause;
+    private ExceptionWithCause cyclicCause;
 
     public ExceptionUtilsTestCase(String name) {
         super(name);
@@ -66,7 +82,7 @@
         ExceptionWithCause a = new ExceptionWithCause(null);
         ExceptionWithCause b = new ExceptionWithCause(a);
         a.setCause(b);
-        recursiveCause = new ExceptionWithCause(a);
+        cyclicCause = new ExceptionWithCause(a);
     }
 
     protected void tearDown() throws Exception {
@@ -75,7 +91,7 @@
         withCause = null;
         jdkNoCause = null;
         selfCause = null;
-        recursiveCause = null;
+        cyclicCause = null;
     }
 
     //-----------------------------------------------------------------------
@@ -131,9 +147,9 @@
         assertSame(nested, ExceptionUtils.getCause(withCause));
         assertSame(null, ExceptionUtils.getCause(jdkNoCause));
         assertSame(selfCause, ExceptionUtils.getCause(selfCause));
-        assertSame(recursiveCause.getCause(), ExceptionUtils.getCause(recursiveCause));
-        assertSame(recursiveCause.getCause().getCause(), ExceptionUtils.getCause(recursiveCause.getCause()));
-        assertSame(recursiveCause.getCause(), ExceptionUtils.getCause(recursiveCause.getCause().getCause()));
+        assertSame(cyclicCause.getCause(), ExceptionUtils.getCause(cyclicCause));
+        assertSame(((ExceptionWithCause) cyclicCause.getCause()).getCause(), ExceptionUtils.getCause(cyclicCause.getCause()));
+        assertSame(cyclicCause.getCause(), ExceptionUtils.getCause(((ExceptionWithCause)
cyclicCause.getCause()).getCause()));
     }
 
     public void testGetCause_ThrowableArray() {
@@ -166,7 +182,7 @@
         assertSame(withoutCause, ExceptionUtils.getRootCause(withCause));
         assertSame(null, ExceptionUtils.getRootCause(jdkNoCause));
         assertSame(null, ExceptionUtils.getRootCause(selfCause));
-        assertSame(recursiveCause.getCause().getCause(), ExceptionUtils.getRootCause(recursiveCause));
+        assertSame(((ExceptionWithCause) cyclicCause.getCause()).getCause(), ExceptionUtils.getRootCause(cyclicCause));
     }
 
     public void testSetCause() {
@@ -220,7 +236,7 @@
         assertEquals(3, ExceptionUtils.getThrowableCount(withCause));
         assertEquals(1, ExceptionUtils.getThrowableCount(jdkNoCause));
         assertEquals(1, ExceptionUtils.getThrowableCount(selfCause));
-        assertEquals(3, ExceptionUtils.getThrowableCount(recursiveCause));
+        assertEquals(3, ExceptionUtils.getThrowableCount(cyclicCause));
     }
 
     //-----------------------------------------------------------------------
@@ -262,11 +278,11 @@
     }
 
     public void testGetThrowables_Throwable_recursiveCause() {
-        Throwable[] throwables = ExceptionUtils.getThrowables(recursiveCause);
+        Throwable[] throwables = ExceptionUtils.getThrowables(cyclicCause);
         assertEquals(3, throwables.length);
-        assertSame(recursiveCause, throwables[0]);
-        assertSame(recursiveCause.getCause(), throwables[1]);
-        assertSame(recursiveCause.getCause().getCause(), throwables[2]);
+        assertSame(cyclicCause, throwables[0]);
+        assertSame(cyclicCause.getCause(), throwables[1]);
+        assertSame(((ExceptionWithCause) cyclicCause.getCause()).getCause(), throwables[2]);
     }
 
     //-----------------------------------------------------------------------
@@ -309,11 +325,11 @@
     }
 
     public void testGetThrowableList_Throwable_recursiveCause() {
-        List throwables = ExceptionUtils.getThrowableList(recursiveCause);
+        List throwables = ExceptionUtils.getThrowableList(cyclicCause);
         assertEquals(3, throwables.size());
-        assertSame(recursiveCause, throwables.get(0));
-        assertSame(recursiveCause.getCause(), throwables.get(1));
-        assertSame(recursiveCause.getCause().getCause(), throwables.get(2));
+        assertSame(cyclicCause, throwables.get(0));
+        assertSame(cyclicCause.getCause(), throwables.get(1));
+        assertSame(((ExceptionWithCause) cyclicCause.getCause()).getCause(), throwables.get(2));
     }
 
     //-----------------------------------------------------------------------



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message