commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gredler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SANDBOX-161) CSVPrinter#escapeAndQuote(String) doesn't adhere to CSV standard
Date Wed, 09 Aug 2006 01:59:14 GMT
     [ http://issues.apache.org/jira/browse/SANDBOX-161?page=all ]

Daniel Gredler updated SANDBOX-161:
-----------------------------------

    Attachment: commons-csv-patch-standard-escaping.txt

Attaching a patch to fix this... a couple of notes:

 - I would talk to whoever initially wrote this code before applying; the non-standard escape
mechanism was very intentional, and I still don't understand why.
 - One of the unit tests checked all sorts of non-standard backslash-escaping corner cases;
it no longer applied, so I removed it.
 - The patch makes a couple of trivial fixes to some typos and smelly one-liners... sorry,
I couldn't help myself!
 - I tried to format my code so that it matches the surrounding code, but it looks like there
are multiple styles used throughout. What's up with that?

Anyways, check it out and let me know what you think!

> CSVPrinter#escapeAndQuote(String) doesn't adhere to CSV standard
> ----------------------------------------------------------------
>
>                 Key: SANDBOX-161
>                 URL: http://issues.apache.org/jira/browse/SANDBOX-161
>             Project: Commons Sandbox
>          Issue Type: Bug
>          Components: CSV
>    Affects Versions: Nightly Builds
>            Reporter: Daniel Gredler
>         Attachments: commons-csv-patch-standard-escaping.txt
>
>
> All the descriptions of the CSV format that I've seen state that:
> - Double quotes (") are escaped using two double quotes (""), rather than a backslash
(\").
> - Embedded line breaks are allowed and don't need to be escaped... just enclose the field
in double quotes.
> - Because backslashes are not used to escape double quotes or line breaks, the backslashes
themselves do not need to be escaped.
> CSVPrinter#escapeAndQuote(String) breaks these rules. Why?
> http://www.creativyst.com/Doc/Articles/CSV/CSV01.htm
> http://en.wikipedia.org/wiki/Comma-separated_values

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message