commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Putrycz, Erik" <Erik.Putr...@nrc-cnrc.gc.ca>
Subject RE: RE: [JCI] RE: JCI, JDT and Tomcat/JBoss
Date Wed, 19 Jul 2006 20:02:38 GMT
The maven dependency I found is 
    <dependency>
      <groupId>tomcat</groupId>
      <artifactId>jasper-compiler-jdt</artifactId>
      <version>5.5.12</version>
    </dependency>

Don't ask me how I found it, I just made a search using the maven
eclipse plugin, except that, I'm not too maven fluent.

The mock + abstract test classes sounds very good to me. 

I just started writing some compiler specific tests but I did not notice
that the main directory has tests in the "test" directory.
Is there any way to import these tests into Eclipse?

Cheers

Erik.



-----Original Message-----
From: tcurdt@gmail.com [mailto:tcurdt@gmail.com] On Behalf Of Torsten
Curdt
Sent: July 19, 2006 4:48
To: Jakarta Commons Developers List
Subject: Re: RE: [JCI] RE: JCI, JDT and Tomcat/JBoss


> Concerning the statics, I was referring to the INSTANCE in 
> JavaCompilerFactory. The instance has a class cache which could 
> potentially lead to non-garbageable stuff.

Well, the usual singleton ...should be alright. But I am not religious
on that one.

> Also concerning the versions, what I did is use the tomcat JDT in the 
> maven dependencies. I'm not even 100% if it is a vanilla 3.1 JDT.

Hm... what else should/could it be?

> Btw, what about moving some of the tests into each compiler project? 
> This way there wouldn't be any issues having 2 different projects.

We could write abstract compiler tests and then extend (implement) them
in the individual compilers. Sure. At the moment the compiler bridge
code is not tested itself.  What is getting tested is currently only in
core.

...and we are using a compiler implementation to do testing of the core.
(At least at the moment) Which makes things a bit ugly. So the testing
setup is not perfect at the moment ....but I am happy to suggestions.

The only idea I have is to mock a compiler in core and then do the real
tests in the individual compiler projects ...based on an common abstract
test code.

cheers
--
Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message