commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (VALIDATOR-89) [validator] ValidatorAction needs thread-safe
Date Wed, 19 Jul 2006 13:31:26 GMT
     [ http://issues.apache.org/jira/browse/VALIDATOR-89?page=all ]

Niall Pemberton reopened VALIDATOR-89:
--------------------------------------

             

> [validator] ValidatorAction needs thread-safe
> ---------------------------------------------
>
>                 Key: VALIDATOR-89
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-89
>             Project: Commons Validator
>          Issue Type: Bug
>         Environment: Operating System: All
> Platform: All
>            Reporter: Takayuki Kaneko
>
> ValidatorAction needs thread-safe because it is cached by other programs, like
> Struts.
> But ValidatorAction has an unthread-safe block.
> Here is a patch below.
> *** ValidatorAction.java        Mon Apr 24 22:41:55 2006
> --- ValidatorAction.java.new    Mon Apr 24 22:44:54 2006
> ***************
> *** 527,536 ****
>           params.put(Validator.VALIDATOR_ACTION_PARAM, this);
>           try {
> !             ClassLoader loader = this.getClassLoader(params);
> !             this.loadValidationClass(loader);
> !             this.loadParameterClasses(loader);
> !             this.loadValidationMethod();
>               Object[] paramValues = this.getParameterValues(params);
> --- 527,540 ----
>           params.put(Validator.VALIDATOR_ACTION_PARAM, this);
>           try {
> !             if (this.validationMethod == null) {
> !                 synchronized(this) {
> !                     ClassLoader loader = this.getClassLoader(params);
> !                     this.loadValidationClass(loader);
> !                     this.loadParameterClasses(loader);
> !                     this.loadValidationMethod();
> !                 }
> !             }
>               Object[] paramValues = this.getParameterValues(params);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message