commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-272) Minor build and checkstyle changes
Date Mon, 10 Jul 2006 12:02:31 GMT
    [ http://issues.apache.org/jira/browse/LANG-272?page=comments#action_12420045 ] 

Niall Pemberton commented on LANG-272:
--------------------------------------

I've committed the JavaDoc/Checkstyle changes and 1, 2 and 4.

Wrt to 3 ("Remove the exclusion of the "text" package from the source distro") - looks like
the target 'dist-build-2.1' should be removed. If we don't remove the exclusion in maven.xml
and the "dist-build" target is used to build lang 2.2 then it will mean that the binary distro
includes classes which are missing from the source distro.

  http://svn.apache.org/viewvc?view=rev&revision=209004

Anyway I'll leave it up to you as I'm not a lang dev - just trying to be pro-active and get
my nitpicks in before a RC was done, rather than after :-)


> Minor build and checkstyle changes
> ----------------------------------
>
>          Key: LANG-272
>          URL: http://issues.apache.org/jira/browse/LANG-272
>      Project: Commons Lang
>         Type: Bug

>     Versions: Nightly Builds
>     Reporter: Niall Pemberton
>     Priority: Minor
>      Fix For: 2.2
>  Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process -
I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message