commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nia...@apache.org
Subject svn commit: r425232 - /jakarta/commons/sandbox/finder/trunk/src/test/org/apache/commons/finder/FileFinderTest.java
Date Mon, 24 Jul 2006 23:55:03 GMT
Author: niallp
Date: Mon Jul 24 16:55:03 2006
New Revision: 425232

URL: http://svn.apache.org/viewvc?rev=425232&view=rev
Log:
Exclude directories from FileFinderTest.testFindSize() - nightly build was failing as it was
finding 2 files rather than 1. Henri worked out that on vmbuild the dir size is 4096 (same
as test file size). So excluding directories from the test

Modified:
    jakarta/commons/sandbox/finder/trunk/src/test/org/apache/commons/finder/FileFinderTest.java

Modified: jakarta/commons/sandbox/finder/trunk/src/test/org/apache/commons/finder/FileFinderTest.java
URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/src/test/org/apache/commons/finder/FileFinderTest.java?rev=425232&r1=425231&r2=425232&view=diff
==============================================================================
--- jakarta/commons/sandbox/finder/trunk/src/test/org/apache/commons/finder/FileFinderTest.java
(original)
+++ jakarta/commons/sandbox/finder/trunk/src/test/org/apache/commons/finder/FileFinderTest.java
Mon Jul 24 16:55:03 2006
@@ -96,7 +96,13 @@
         assertEquals(1, files.length);
     }
 
+    /**
+     * N.B. dir size on vmbuild is 4k which caused this test to fail in that
+     *      environment (incl. nightly build) - so excluding directories.
+     *      TODO - currently just one 4k file - need non-4k files for proper test
+     */
     public void testFindSize() {
+        options.put(Finder.FILE, null);
         options.put(Finder.SIZE, "4k");
         File[] files = finder.find(new File(dir, "size"), options);
         assertEquals(1, files.length);



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message