commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gredler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SANDBOX-160) small optimization in CSVPrinter#print(String)
Date Fri, 28 Jul 2006 23:45:14 GMT
    [ http://issues.apache.org/jira/browse/SANDBOX-160?page=comments#action_12424219 ] 
            
Daniel Gredler commented on SANDBOX-160:
----------------------------------------

Note that the code immediately below this loop expects char c to be the last char in the string,
so you would have to add a line below the loop:

c = value.charAt( value.length() - 1 );

> small optimization in CSVPrinter#print(String)
> ----------------------------------------------
>
>                 Key: SANDBOX-160
>                 URL: http://issues.apache.org/jira/browse/SANDBOX-160
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: CSV
>    Affects Versions: Nightly Builds
>            Reporter: Daniel Gredler
>            Priority: Trivial
>
> The following code in CSVPrinter#print(String) could use a break:
> for (int i = 0; i < value.length(); i++) {
>     c = value.charAt(i);
>     if (c == '"' || c == this.strategy.getDelimiter() || c == '\n' || c == '\r') {
>         quote = true;
>         >>> BREAK OUT OF LOOP HERE <<<
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message