commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-87) Provide a convenience mehod in FileFilterUtils to create a Size Range filter
Date Mon, 24 Jul 2006 16:31:14 GMT
    [ http://issues.apache.org/jira/browse/IO-87?page=comments#action_12423093 ] 
            
Niall Pemberton commented on IO-87:
-----------------------------------

IMO minimumSize and maximumSize indicate that both are "inclusive" and therefore its unecessary
to rename the parameters. I agree that the javadoc could be clearer in the method description
and will fix that. Something like

    /**
     * Returns a filter that accepts files whose size is <= minimum size
     * and >=  maximum size.
     */

Currently this method implementation adds 1 to the maximumSize specified to achieve the <=
maximum - but I've just opened a bug (IO-89) relating to the inconsistency in SizeFileFilter
(and AgeFileFilter) which it would be good to resolve before fixing this.



> Provide a convenience mehod in FileFilterUtils to create a Size Range filter
> ----------------------------------------------------------------------------
>
>                 Key: IO-87
>                 URL: http://issues.apache.org/jira/browse/IO-87
>             Project: Commons IO
>          Issue Type: New Feature
>          Components: Filters
>    Affects Versions: 1.2
>            Reporter: Niall Pemberton
>         Assigned To: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.3
>
>
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining
two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message