Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 70103 invoked from network); 2 May 2006 17:54:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 May 2006 17:54:46 -0000 Received: (qmail 16681 invoked by uid 500); 2 May 2006 17:54:27 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 16320 invoked by uid 500); 2 May 2006 17:54:26 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 16309 invoked by uid 99); 2 May 2006 17:54:26 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2006 10:54:26 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [217.20.116.97] (HELO s375.deinprovider.de) (217.20.116.97) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2006 10:54:23 -0700 Received: from [127.0.0.1] (217-20-116-97.internetserviceteam.com [217.20.116.97]) by s375.deinprovider.de (Postfix) with ESMTP id 2D48D104C084 for ; Tue, 2 May 2006 19:55:03 +0200 (CEST) Message-ID: <44579D3F.1060303@possessed.de> Date: Tue, 02 May 2006 19:56:15 +0200 From: "C. Grobmeier" User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [compress] New draft 5 References: <4454A322.7020800@possessed.de> <44553D4A.6060208@sourcelabs.com> <6bde122b0604301738o416f241ale7caab3a6f29df0b@mail.gmail.com> <98e4f1cd0605020344s7ae7eb0dm331a29d83ef47e5@mail.gmail.com> <98e4f1cd0605020433x63148992sf6146e737b338195@mail.gmail.com> <31cc37360605021048l38d4558er19e516c05f3b328e@mail.gmail.com> In-Reply-To: <31cc37360605021048l38d4558er19e516c05f3b328e@mail.gmail.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> So my comments: >> >> o Don't like that compressor does both compression and decompression. > > I'm ambivalent on this one. > If we would do so, we have 4 different interfaces. But i like the look. >> o Always use File not String > > +1. Only use 'String filename' when you're doing something to a > filename - otherwise we bloat the APIs for the sake of a new > File(xxx). It's not worth it. Agreed, i will delete that. > Also, the setXxx stuff seems a bit unnecessary. > > For the interface, minimal and stateless seem like important goals. > Having setXxx just means that the implementors have to worry about > thread safety. OK, my new draft will remind that. I will keep it pure ;-) Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEV50/kv8rKBUE/T4RAiYiAKCJEGc8eQ07MgenqF/BNBjr4rQ8UQCfRIhL 8K3+oBrOYvXuAGIyUuR/yQM= =UBTS -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org