Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 47817 invoked from network); 29 May 2006 19:45:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 May 2006 19:45:50 -0000 Received: (qmail 26202 invoked by uid 500); 29 May 2006 19:45:48 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 26125 invoked by uid 500); 29 May 2006 19:45:47 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 26109 invoked by uid 500); 29 May 2006 19:45:47 -0000 Received: (qmail 26105 invoked by uid 99); 29 May 2006 19:45:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 May 2006 12:45:47 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 May 2006 12:45:46 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 7DBAC1A983A; Mon, 29 May 2006 12:45:26 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r410143 - in /jakarta/commons/proper/attributes/trunk: api/src/java/org/apache/commons/attributes/RuntimeAttributeRepository.java build.xml compiler/project.xml project.properties project.xml site/xdocs/changelog.xml site/xdocs/index.xml Date: Mon, 29 May 2006 19:45:25 -0000 To: commons-cvs@jakarta.apache.org From: leosutic@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060529194526.7DBAC1A983A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: leosutic Date: Mon May 29 12:45:24 2006 New Revision: 410143 URL: http://svn.apache.org/viewvc?rev=410143&view=rev Log: (empty) Modified: jakarta/commons/proper/attributes/trunk/api/src/java/org/apache/commons/attributes/RuntimeAttributeRepository.java jakarta/commons/proper/attributes/trunk/build.xml jakarta/commons/proper/attributes/trunk/compiler/project.xml jakarta/commons/proper/attributes/trunk/project.properties jakarta/commons/proper/attributes/trunk/project.xml jakarta/commons/proper/attributes/trunk/site/xdocs/changelog.xml jakarta/commons/proper/attributes/trunk/site/xdocs/index.xml Modified: jakarta/commons/proper/attributes/trunk/api/src/java/org/apache/commons/attributes/RuntimeAttributeRepository.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/api/src/java/org/apache/commons/attributes/RuntimeAttributeRepository.java?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/api/src/java/org/apache/commons/attributes/RuntimeAttributeRepository.java (original) +++ jakarta/commons/proper/attributes/trunk/api/src/java/org/apache/commons/attributes/RuntimeAttributeRepository.java Mon May 29 12:45:24 2006 @@ -99,6 +99,15 @@ private final Class clazz; /** + * Synchronization lock for sealing the repository. We use this instead of + * synchronizing on the instance (this), since the sync:ing was added + * in 2.2 and we don't want to break any code. + * + * @since 2.2 + */ + private final Object syncLock = new Object (); + + /** * Create a new runtime repository. * * @since 2.1 @@ -113,6 +122,7 @@ * @since 2.1 */ public void addClassAttribute (Object attribute) { + checkSealed (); classAttributes.add (attribute); } @@ -124,8 +134,10 @@ * @since 2.1 */ private void checkSealed () throws IllegalStateException { - if (sealed) { - throw new IllegalStateException ("RuntimeAttributeRepository has been sealed."); + synchronized (syncLock) { + if (sealed) { + throw new IllegalStateException ("RuntimeAttributeRepository has been sealed."); + } } } @@ -364,6 +376,8 @@ * @since 2.1 */ public void seal () { - sealed = true; + synchronized (syncLock) { + sealed = true; + } } } Modified: jakarta/commons/proper/attributes/trunk/build.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/build.xml?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/build.xml (original) +++ jakarta/commons/proper/attributes/trunk/build.xml Mon May 29 12:45:24 2006 @@ -53,7 +53,8 @@ - + Modified: jakarta/commons/proper/attributes/trunk/compiler/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/compiler/project.xml?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/compiler/project.xml (original) +++ jakarta/commons/proper/attributes/trunk/compiler/project.xml Mon May 29 12:45:24 2006 @@ -40,14 +40,6 @@ ant 1.5 - - qdox @@ -58,15 +50,15 @@ org.apache.commons commons-attributes-api - 2.2-SNAPSHOT + 2.2 - + Modified: jakarta/commons/proper/attributes/trunk/project.properties URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/project.properties?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/project.properties (original) +++ jakarta/commons/proper/attributes/trunk/project.properties Mon May 29 12:45:24 2006 @@ -21,8 +21,8 @@ ###################################################################### # Specify the JVM version. ###################################################################### -#maven.compile.source= -#maven.compile.target= +maven.compile.source=1.4 +maven.compile.target=1.4 ###################################################################### # Jar Manifest Additional Attributes Modified: jakarta/commons/proper/attributes/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/project.xml?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/project.xml (original) +++ jakarta/commons/proper/attributes/trunk/project.xml Mon May 29 12:45:24 2006 @@ -31,7 +31,7 @@ http://jakarta.apache.org/images/jakarta-logo.gif - 2.2-SNAPSHOT + 2.2 2003 Commons Attributes A package for handling runtime information about types (including Java classes) Modified: jakarta/commons/proper/attributes/trunk/site/xdocs/changelog.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/site/xdocs/changelog.xml?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/site/xdocs/changelog.xml (original) +++ jakarta/commons/proper/attributes/trunk/site/xdocs/changelog.xml Mon May 29 12:45:24 2006 @@ -24,6 +24,17 @@ +
+
    +
  • +

    + Fixed a potential bug in RuntimeAttributeRepository - the seal() method and the + checkSealed() method weren't synchronized properly. +

    +
    • +
+
+
  • Modified: jakarta/commons/proper/attributes/trunk/site/xdocs/index.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/attributes/trunk/site/xdocs/index.xml?rev=410143&r1=410142&r2=410143&view=diff ============================================================================== --- jakarta/commons/proper/attributes/trunk/site/xdocs/index.xml (original) +++ jakarta/commons/proper/attributes/trunk/site/xdocs/index.xml Mon May 29 12:45:24 2006 @@ -39,6 +39,11 @@

    Please see the change log for summaries of code changes.

    +

    2006-06-29

    +
      +

    • Attributes 2.2 released!

      • +
    +

    2004-08-15

    • Attributes 2.1 released!

      • --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org