commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukas Theussl (JIRA)" <commons-...@jakarta.apache.org>
Subject [jira] Updated: (JELLY-187) Wrong composite expression evaluation
Date Sun, 14 May 2006 06:09:07 GMT
     [ http://issues.apache.org/jira/browse/JELLY-187?page=all ]

Lukas Theussl updated JELLY-187:
--------------------------------

    Attachment: JELLY-187.patch

Aha! That's exactly the reason for my careful phrasing above.
There was a switch case in the code before which I removed because I didn't know
what it was used for. Funny thing is, just a few days ago someone asked on IRC
how one could achieve this with jelly, - nobody knew. Well, if it's
undocumented...

I added a new method for testing this because using assertExpression() always
fails with such expressions (containing '$${'). The expression is correctly
constructed but the inverse operation does not work: the getExpressionText()
method does not return the initial string. However, I checked that this did not
work already before my patch, so it is not a regression. :) I don't know if it's
important and worth fixing though.

Anyway, thanks for spotting this (and educating me! ;) ), it would have broken
quite a few things indeed!

> Wrong composite expression evaluation
> -------------------------------------
>
>          Key: JELLY-187
>          URL: http://issues.apache.org/jira/browse/JELLY-187
>      Project: Jelly
>         Type: Bug

>   Components: core / taglib.core
>     Versions: 1.0-RC1, 1.0, 1.0-RC2
>     Reporter: dion gillard
>      Fix For: 1.0.1
>  Attachments: JELLY-187.patch, JELLY-187.patch
>
> I have tried to add the following test consdtion in method testExpresssions()
> from org.apache.commons.jelly.expression.TestExpressions.java:
> assertExpression("$type${topping}", "$typecheese");
> but it fails saying that it should be:
> assertExpression("$type${topping}", "typecheese");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message