commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "C. Grobmeier" <grobme...@possessed.de>
Subject Re: [compress] New draft 5
Date Tue, 02 May 2006 17:56:15 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> So my comments:
>>
>> o Don't like that compressor does both compression and decompression.
> 
> I'm ambivalent on this one.
> 

If we would do so, we have 4 different interfaces. But i like the look.

>> o Always use File not String
> 
> +1. Only use 'String filename' when you're doing something to a
> filename - otherwise we bloat the APIs for the sake of a new
> File(xxx). It's not worth it.

Agreed, i will delete that.

> Also, the setXxx stuff seems a bit unnecessary.
> 
> For the interface, minimal and stateless seem like important goals.
> Having setXxx just means that the implementors have to worry about
> thread safety.

OK, my new draft will remind that. I will keep it pure ;-)

Chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEV50/kv8rKBUE/T4RAiYiAKCJEGc8eQ07MgenqF/BNBjr4rQ8UQCfRIhL
8K3+oBrOYvXuAGIyUuR/yQM=
=UBTS
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message