commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell" <flame...@gmail.com>
Subject Re: [compress] New draft 5
Date Tue, 02 May 2006 17:48:25 GMT
On 5/2/06, Torsten Curdt <tcurdt@apache.org> wrote:
> Sorry, joining the party so late ...but this thread let me to actually
> have a look ;)
>
> So my comments:
>
> o Don't like that compressor does both compression and decompression.

I'm ambivalent on this one.

> o Always use File not String

+1. Only use 'String filename' when you're doing something to a
filename - otherwise we bloat the APIs for the sake of a new
File(xxx). It's not worth it.

Also, the setXxx stuff seems a bit unnecessary.

For the interface, minimal and stateless seem like important goals.
Having setXxx just means that the implementors have to worry about
thread safety.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message