commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <skitch...@apache.org>
Subject Re: svn commit: r405927 - in /jakarta/commons/proper/collections/trunk/src/java/org/apache/commons/collections: ./ buffer/ functors/ keyvalue/ list/
Date Sat, 13 May 2006 05:28:22 GMT
On Fri, 2006-05-12 at 22:57 +0000, scolebourne@apache.org wrote:
> ---
> jakarta/commons/proper/collections/trunk/src/java/org/apache/commons/collections/functors/OnePredicate.java
(original)
> +++
> jakarta/commons/proper/collections/trunk/src/java/org/apache/commons/collections/functors/OnePredicate.java
Fri May 12 15:57:03 2006
> @@ -41,7 +41,10 @@
>      
>      /**
>       * Factory to create the predicate.
> -     * 
> +     * <p>
> +     * If the array is size zero, the predicate always returns false.
> +     * If the array is size one, then that predicate is returned.
> +     * 

I believe this behaviour is different from that in previous releases;
prior releases would throw an IllegalArgumentException if an array of
size 0 or 1 was passed. 

In this case, should there be a note that any code taking advantage of
this new behaviour is not backwards-compatible with pre-3.2  versions? 

It's not a "backwards incompatibility", because old code will work with
this new version. However code that works with this lib work with older
versions.

When a new method is added, we use @since to let users know that code
using this method can't run on earlier versions. However when
functionality of an existing method is enhanced, what is the general
convention? Is it worth noting or not?

Cheers,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message