commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mario Ivankovits (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (VFS-50) Threading issue with AbstractFileSystem.fireEvent
Date Thu, 25 May 2006 19:51:30 GMT
     [ http://issues.apache.org/jira/browse/VFS-50?page=all ]
     
Mario Ivankovits resolved VFS-50:
---------------------------------

    Fix Version: Nightly Builds
     Resolution: Fixed
      Assign To: Mario Ivankovits

Well, this wasnt really a "threading issue" but a normal bug.
Since every access to the "listeners" is synchronized on the "listenerMap" both are save.
There is no access to the "listeners" outside an "listenerMap" synchronization.

I slightly modified your patch.

Thanks for reporting it.

> Threading issue with AbstractFileSystem.fireEvent
> -------------------------------------------------
>
>          Key: VFS-50
>          URL: http://issues.apache.org/jira/browse/VFS-50
>      Project: Commons VFS
>         Type: Bug

>     Reporter: Chris DiGiano
>     Assignee: Mario Ivankovits
>     Priority: Minor
>      Fix For: Nightly Builds

>
> I make heavy use of DelegateFileObject in my code and recently ran into a threading issue
when a change in one file was trying to automatically update dependent DelegateFileObjects.
While events where still being propagated, one DelegateFileObject removed itself as an event
listener. This caused an index-of-range problem in AbstractFileSystem.fireEvent because the
listener list had shrunk, but the "count" had already been fixed.
> It appears that the current implementation of fireEvent is not entirely thread safe,
if event handlers can still change the listener list in place. I will attach a patch that
works for me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message