commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31343] - [dbcp] setReadOnly & setAutoCommit called too many times
Date Thu, 20 Apr 2006 08:38:15 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31343>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31343





------- Additional Comments From pretbrao@yahoo.co.in  2006-04-20 08:38 -------
(In reply to comment #2)
> Fixed in r390763, nightlies starting 2 Apr 2006.

I just looked at the source code and activateObject() method in
PoolableConnectionfactory.java has been enhanced to first call
getAutoCommit() and then if needed call setAutoCommit().

But as I have seen with OptimizeIt, passivateObject() too calls 
setAutoCommit() without checking any condition, and that again 
causes network overhead.

Our application experiences about 20% difference in performance due 
to this network overhead.

a) should it too be fixed ?

b) Is there no way to completely get rid of this network overhead due to
autoCommit? For example, if my application is sure that it will always use
autoCommit(true), then without any overhead I should be able to achieve it.
So, there should be a way to tell the DBCP that. "let the application manage 
all operations related to setting/getting auto commit". Same logic applies to 
operation, that can be optionally turbed off. For example, here by optionally
not executing any code related to _defaultAutoCommit, we might achieve it.

Thanks
Preetam

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message