commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory" <ggreg...@seagullsoftware.com>
Subject RE: [lang] Entities question
Date Tue, 18 Apr 2006 15:23:12 GMT
Refactor away!

Gary

> -----Original Message-----
> From: Henri Yandell [mailto:flamefew@gmail.com]
> Sent: Tuesday, April 18, 2006 12:29 AM
> To: Jakarta Commons Developers List
> Subject: [lang] Entities question
> 
> Any ideas why there are unescape(String);String and unescape(Writer,
> String) implementations in Entities - independently implemented? They
> look like clones of each other - just one has nicer variable names.
> 
> Seems to me that:
> 
> a) One should call the other.
> b) One could be deleted (given that Entities isn't public).
> 
> In the latter case, there are two users of the methods: unescapeHtml
> calls the Writer,String and unescapeXml calls the String; so we would
> delete one and make the two unescapeXxx methods call the same method.
> 
> Same applies for the escape() variants.
> 
> Hen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message