commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <skitch...@apache.org>
Subject Re: [logging] redux: include jdk logger in API jar?
Date Mon, 10 Apr 2006 06:58:40 GMT
On Mon, 2006-04-10 at 14:16 +1000, Torsten Curdt wrote:
> On 4/6/06, Dennis Lundberg <dennisl@apache.org> wrote:
> > robert burrell donkin wrote:
> > > remy ran a regression test for RC6 (thanks :)
> > >
> > > we no long ship the jdk logger in API jar. however, tomcat uses jdk
> > > logger as it's default. so, by excluding the jdk logger, JCL 1.1 is no
> > > longer a drop in replacement at least for tomcat.
> > >
> > > so, i thought it'd be a good time to reconsider the decision to exclude
> > > the jdk logger.
> > >
> > > opinions?
> > >
> > > - robert
> >
> > I think we should allow for a smooth upgrade path, especially for Tomcat
> > users. If that means putting back the jdk logger, then let's do that.
> 
> -1
> 
> It's an API jar and should not include an implementation!
> 
> Why doesn't tomcat use the full JCL jar?

I have no idea. Probably some historical reason.

However this JCL release has taken so long now that I think it's worth
accepting a little bit of ugliness to get this out the door. No-one can
see any practical problem with having the JDK14Logger in the api jar,
and in practice it hasn't caused any problems in the 1.0.4 release
either. 

If we have it in there, there is less confusion on upgrades; api.jar for
1.0.4 can be replaced by api.jar for 1.1. There is also less risk; while
I can't see any behavioural changes that might occur by replacing the
old -api.jar with a new full jarfile we can avoid *any* change by making
things the same as the old release.

The documentation for 1.1 makes it clear that the -api.jar has no real
purpose, and should generally be avoided. Hopefully we can encourage the
next tomcat release to include the full JCL 1.1 jar.

The price paid is just mild offense to purists, who *are* correct that
this class doesn't really belong in a jar labelled "api".

Right now, I'm rather tired of JCL (and I'm sure Robert feels worse).
Anything that gets this out the door without any more debate and testing
is good!

Cheers,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message