Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 47624 invoked from network); 29 Mar 2006 07:03:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 Mar 2006 07:03:41 -0000 Received: (qmail 6086 invoked by uid 500); 29 Mar 2006 07:03:37 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 5995 invoked by uid 500); 29 Mar 2006 07:03:37 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 5984 invoked by uid 99); 29 Mar 2006 07:03:37 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2006 23:03:37 -0800 X-ASF-Spam-Status: No, hits=1.3 required=10.0 tests=RCVD_IN_BL_SPAMCOP_NET,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of sandymac@gmail.com designates 64.233.166.177 as permitted sender) Received: from [64.233.166.177] (HELO pproxy.gmail.com) (64.233.166.177) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2006 23:03:36 -0800 Received: by pproxy.gmail.com with SMTP id b36so337120pyb for ; Tue, 28 Mar 2006 23:03:16 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=n2qkTUegj4LNXGgG7EoqoWiniYkkDohGs+QW4zMfpIbcjfADjgLCGGlJ4spKQCfebybknfIiqCA0zbplENaRWgR/9LrPlDmND5ppwA1qZGLkMKdykH1zSyY544vci1IPkxOIexnmZa2HzyTQ/jDRZILu6Rvpi0jetMvQkiCEugg= Received: by 10.35.78.13 with SMTP id f13mr196106pyl; Tue, 28 Mar 2006 23:02:58 -0800 (PST) Received: by 10.35.34.16 with HTTP; Tue, 28 Mar 2006 23:02:58 -0800 (PST) Message-ID: <6bde122b0603282302i56fa26c2h1c35189f098c6484@mail.gmail.com> Date: Wed, 29 Mar 2006 02:02:58 -0500 From: "Sandy McArthur" Sender: sandymac@gmail.com To: "Jakarta Commons Developers List" Subject: Re: [all] Line width and such minutiae In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 3/29/06, J=F6rg Schaible wrote: > Phil Steitz wrote on Wednesday, March 29, 2006 4:27 AM: > > > On 3/28/06, Martin Cooper wrote: > >> On 3/28/06, Gary Gregory wrote: > >>> > >>>> -----Original Message----- > >>>> From: mfncooper@gmail.com [mailto:mfncooper@gmail.com] On Behalf > >>>> Of Martin Cooper Sent: Tuesday, March 28, 2006 3:02 PM > >>>> To: Jakarta Commons Developers List > >>>> Subject: Re: [all] Line width and such minutiae > >>>> > >>>> On 3/28/06, Henri Yandell wrote: > >>>>> > >>>>> On 3/28/06, Phil Steitz wrote: > >>>>> > >>>>>> My personal preference is 80 column line widths, partly because > >>>>>> this makes diffs readable. > >>>>> > >>>>> Sorry, forgot to add this to the other email. > >>>>> > >>>>> For the record, I like 120 column line widths. Java's a verbose > >>>>> language, 80 feels cramped. People can print in landscape :) > >>>> > >>>> > >>>> For me, printing is not the issue, side-by-side diffs are the > >>>> issue. I hate having to scroll horizontally all the time to see > >>>> the actual diffs. That's why I'm with Phil on 80 character widths. > >>> > >>> This sounds to me like a problem with a particular diff tool. I do > >>> not think we should restrict our source code based on the > >>> limitations of /one/ tool. > > Try to use proportional fonts. Ist arted using it years ago and I will ne= ver go back. So linelength gets somewhat pointless :) > > >>> For those of us using Eclipse, this is not an issue since the tool > >>> (Eclipse) presents a nice user-interface that allows me to focus on > >>> the nature of the changes as opposed to the changes and the format > >>> the changes are given in. > >>> > >>> We use 120 at work. I think we got the idea from Jakarata Commons > >>> but I cannot find a link right now. Plenty of Commons projects use > >>> 120, so the number must come from some previous agreement. > >> > >> > >> Perhaps agreement among some subset of us - the components I've > >> worked on use 80 characters. ;-) > >> > > > > The number 80 has numerological properties that imbue the code with a > > special quality that obviously only you and I appreciate, Martin. > > > > Mailers wrapping commit diffs is a sign that we have offended the Gods > > when we code "beyond the end of the card" ;-) > > STOP. We must limit the line length to 76. Any longer line will be wrappe= d by my mailer. > > :D I'd like to formally apologize for any of the times I've been more than the 4th person to respond in a thread. Oops I'm doing it now. :-) A little more seriously though, the svn-to-email script really could use some modernization. We live in an age of mime email and each part of commit message really should be it's own mime part of type text/x-patch or something. (I don't see an existing patch mime-type: http://www.iana.org/assignments/media-types/ ) Part of the problem something that is more structured than text/plain is being labeled as such. This could be a first step to mail clients with built in colorized diff view. -- Sandy McArthur "He who dares not offend cannot be honest." - Thomas Paine --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org