commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented
Date Fri, 31 Mar 2006 02:48:16 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39109>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





------- Additional Comments From scohen@apache.org  2006-03-31 03:48 -------
To answer your question, I guess your choices are

1.  Redo your code to use Regular Expressions and inherit from
ConfigurableFTPFileEntryParserImpl which would be my recommendation.

2.  If really don't want to use regex or it's impossible to write the parser
this way (i can't tell from your patch), then you should probably inherit from
FTPFileEntryParserImpl 

As far as copyright goes, just start with what's in MVSFTPEntryParser.java.  You
can change every line of code after that if you like.

However, it looks like you still have some work to do.  Your code, I see, still
has TODOs in it.  If you're going to change the parser implementation, let's get
as complete an implementation as you can.  

Out of curiosity, would you mind also explaining for our benefit what these ZOS
and PDS things are?  Comments might be a good place to do that.  This OS is much
different from many of the others we handle.

Finally, don't forget the JUnit tests.  Please do not submit your patch until
all existing tests pass.  And please add more tests that exercise the new
functionalities you are adding.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message