commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject svn commit: r387063 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Date Sun, 19 Mar 2006 23:28:33 GMT
Author: dion
Date: Sun Mar 19 15:28:31 2006
New Revision: 387063

URL: http://svn.apache.org/viewcvs?rev=387063&view=rev
Log:
Combine nested if - pmd report.

Modified:
    jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java

Modified: jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java?rev=387063&r1=387062&r2=387063&view=diff
==============================================================================
--- jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
(original)
+++ jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Sun Mar 19 15:28:31 2006
@@ -120,12 +120,10 @@
             tree = parser.parse(new StringReader(expr));
         }
 
-        if (tree.jjtGetNumChildren() > 1) {
-            if (log.isWarnEnabled()) {
-                log.warn( "The JEXL Expression created will be a reference"
-                    + " to the first expression from the supplied script: \""
-                    + expression + "\" " );
-            }
+        if (tree.jjtGetNumChildren() > 1 && log.isWarnEnabled()) {
+            log.warn( "The JEXL Expression created will be a reference"
+                + " to the first expression from the supplied script: \""
+                + expression + "\" " );
         }
 
         // Must be a simple reference, expression, statement or if, otherwise



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message