commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: svn commit: r381879 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Date Wed, 01 Mar 2006 20:47:34 GMT
On Wed, 2006-03-01 at 02:49 +0000, skitching@apache.org wrote:
> Author: skitching

<snip>

> --- jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
(original)
> +++ jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Tue Feb 28 18:49:34 2006
> @@ -465,6 +465,20 @@
>                          + "]. Trying alternative implementations...");
>              }
>              ;  // ignore
> +        } catch(Exception e) {
> +            // This is not consistent with the behaviour when a bad LogFactory class
is
> +            // specified in a services file.

+1

IMHO the services behaviour is preferable. if the user cares about this
failure then they can turn on diagnostics to discover the cause. 

can anyone think of a good reason not to remove the re-throw?

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message