commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdon...@apache.org
Subject svn commit: r377185 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
Date Sun, 12 Feb 2006 14:51:36 GMT
Author: rdonkin
Date: Sun Feb 12 06:51:36 2006
New Revision: 377185

URL: http://svn.apache.org/viewcvs?rev=377185&view=rev
Log:
Added single quotes to diagnostic class names to improve readability.

Modified:
    jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java

Modified: jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java?rev=377185&r1=377184&r2=377185&view=diff
==============================================================================
--- jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
(original)
+++ jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
Sun Feb 12 06:51:36 2006
@@ -889,7 +889,7 @@
                                    boolean affectState) 
             throws LogConfigurationException {       
 
-        logDiagnostic("Attempting to instantiate " + logAdapterClassName);
+        logDiagnostic("Attempting to instantiate '" + logAdapterClassName + "'");
         
         Object[] params = { logCategory };
         Log logAdapter = null;
@@ -907,9 +907,9 @@
             // Loop through the classloader hierarchy trying to find
             // a viable classloader.
             logDiagnostic(
-                    "Trying to load "
+                    "Trying to load '"
                     + logAdapterClassName
-                    + " from classloader "
+                    + "' from classloader "
                     + objectId(currentCL));
             try {
                 Class c = null;
@@ -921,9 +921,9 @@
                     // trying higher up in the hierarchy in this case..
                     String msg = "" + originalClassNotFoundException.getMessage();
                     logDiagnostic(
-                        "The log adapter "
+                        "The log adapter '"
                         + logAdapterClassName
-                        + " is not available via classloader " 
+                        + "' is not available via classloader " 
                         + objectId(currentCL)
                         + ": "
                         + msg.trim());
@@ -940,9 +940,9 @@
                         // no point continuing: this adapter isn't available
                         msg = "" + secondaryClassNotFoundException.getMessage();
                         logDiagnostic(
-                            "The log adapter "
+                            "The log adapter '"
                             + logAdapterClassName
-                            + " is not available via the LogFactoryImpl class classloader:
"
+                            + "' is not available via the LogFactoryImpl class classloader:
"
                             + msg.trim());
                         break;
                     }
@@ -980,9 +980,9 @@
                 // in the hierarchy in this case..
                 String msg = "" + e.getMessage();
                 logDiagnostic(
-                    "The log adapter "
+                    "The log adapter '"
                     + logAdapterClassName
-                    + " is missing dependencies when loaded via classloader "
+                    + "' is missing dependencies when loaded via classloader "
                     + objectId(currentCL)
                     + ": "
                     + msg.trim());
@@ -996,9 +996,9 @@
                 // library could not be found.
                 String msg = "" + e.getMessage();
                 logDiagnostic(
-                    "The log adapter "
+                    "The log adapter '"
                     + logAdapterClassName
-                    + " is unable to initialize itself when loaded via classloader "
+                    + "' is unable to initialize itself when loaded via classloader "
                     + objectId(currentCL)
                     + ": "
                     + msg.trim());
@@ -1090,20 +1090,20 @@
             try {
                 this.logMethod = logAdapterClass.getMethod("setLogFactory",
                                                logMethodSignature);
-                logDiagnostic("Found method setLogFactory(LogFactory) in " 
-                              + logAdapterClassName);
+                logDiagnostic("Found method setLogFactory(LogFactory) in '" 
+                              + logAdapterClassName + "'");
             } catch (Throwable t) {
                 this.logMethod = null;
                 logDiagnostic(
-                    "info:" + logAdapterClassName 
-                    + " from classloader " + objectId(currentCL)
+                    "info: '" + logAdapterClassName 
+                    + "' from classloader " + objectId(currentCL)
                     + " does not declare optional method "
                     + "setLogFactory(LogFactory)");
             }
             
             logDiagnostic(
-                "Log adapter " + logAdapterClassName 
-                + " from classloader " + objectId(currentCL)
+                "Log adapter '" + logAdapterClassName 
+                + "' from classloader " + objectId(currentCL)
                 + " has been selected for use.");
         }
         
@@ -1248,8 +1248,8 @@
                                        ClassLoader classLoader,
                                        Throwable discoveryFlaw) {
         
-        logDiagnostic("Could not instantiate Log "
-                      + logAdapterClassName + " -- "
+        logDiagnostic("Could not instantiate Log '"
+                      + logAdapterClassName + "' -- "
                       + discoveryFlaw.getLocalizedMessage());        
 
         if (!allowFlawedDiscovery) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message