Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 29592 invoked from network); 19 Jan 2006 20:26:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Jan 2006 20:26:17 -0000 Received: (qmail 23157 invoked by uid 500); 19 Jan 2006 20:26:13 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 23084 invoked by uid 500); 19 Jan 2006 20:26:13 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 23073 invoked by uid 99); 19 Jan 2006 20:26:13 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2006 12:26:13 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [69.55.235.171] (HELO mvdb.net) (69.55.235.171) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 19 Jan 2006 12:26:12 -0800 Received: (qmail 31109 invoked from network); 19 Jan 2006 20:25:52 -0000 Received: from unknown (HELO [10.21.21.40]) (80.126.215.98) by 69.55.235.171 with SMTP; Thu, 19 Jan 2006 20:25:52 +0000 Message-ID: <43CFF5E4.4020608@mvdb.net> Date: Thu, 19 Jan 2006 21:26:12 +0100 From: Martin van den Bemt User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [logging] Bug 38174 and JCL 1.1 References: <5169.1137694664@www036.gmx.net> <1137702185.5095.36.camel@knossos.elmet> In-Reply-To: <1137702185.5095.36.camel@knossos.elmet> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi robert, See 13.4.8 final Fields and Constants at http://java.sun.com/docs/books/jls/second_edition/html/binaryComp.doc.html Short answer : yes and no :) Mvgr, Martin robert burrell donkin wrote: > On Thu, 2006-01-19 at 19:17 +0100, Boris Unckel wrote: > >>Hello, >> >>Simon Kitching wrote: >> >>>>>NB: I'm hoping to knock JCL1.1 into releasable state over the coming >>>>>weekend and hold a vote on creating the first RC. >>>> >>>>Please check to put the patch in bug 38174 into RC. Even if you decide >>>>against the logic in the new "doLog" methods, it would be nice to have >>>>the other cleanup (javadoc, same null behaviour for all classes). >>> >>>Please check my comments on that bugzilla entry. >>> >> >>I have read your comments and opinions in the bugzilla entry[1]. >>As I do not want to put so much time in a more or less boring task >>(improving the JavaDoc and care for doLog single method logic is a lot of >>copy and correct paste) I have removed anything of the exception behaviour. >>I have also removed the String.valueOf when the underlying logger accepts >>objects as message. >> >>Every file has single patch. With accident cause I did an format after >>removing the exception handling - sorry for that, it will cause more diff >>than is really different. >> >>Please consider again to put this into release. > > > i'm going through the patches (by hand) now. > > i notice that a lot of the parameters are now declared final (which is - > usually - good). i would have expected that this should not effect > binary compatibility but unfortunately, i can't find anywhere in the JLS > where this is definitely specified. i'm very reluctant to add any > changes which risk (at all) binary compatibility issues. > > anyone know of a definitive reference? > > - robert > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-dev-help@jakarta.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org