Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 24428 invoked from network); 30 Jan 2006 22:28:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 30 Jan 2006 22:28:11 -0000 Received: (qmail 33476 invoked by uid 500); 30 Jan 2006 22:28:09 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 32941 invoked by uid 500); 30 Jan 2006 22:28:08 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 32930 invoked by uid 500); 30 Jan 2006 22:28:08 -0000 Received: (qmail 32925 invoked by uid 99); 30 Jan 2006 22:28:07 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2006 14:28:07 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 30 Jan 2006 14:28:07 -0800 Received: (qmail 24283 invoked by uid 65534); 30 Jan 2006 22:27:47 -0000 Message-ID: <20060130222747.24282.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r373612 - /jakarta/commons/dormant/feedparser/trunk/src/java/org/apache/commons/feedparser/RSSFeedParser.java Date: Mon, 30 Jan 2006 22:27:46 -0000 To: commons-cvs@jakarta.apache.org From: mvdb@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: mvdb Date: Mon Jan 30 14:27:44 2006 New Revision: 373612 URL: http://svn.apache.org/viewcvs?rev=373612&view=rev Log: In using the feedparser API I've encountered a number of RSS feeds that are missing the lenght attribute for enclosures. This causes feedparser to throw a NPE. The standard does say that length is a required element, but in practice it's being ignored. Applied bugzilla issue 38225. Thanx Andrew McCall andrew.mccall at goroam.net Modified: jakarta/commons/dormant/feedparser/trunk/src/java/org/apache/commons/feedparser/RSSFeedParser.java Modified: jakarta/commons/dormant/feedparser/trunk/src/java/org/apache/commons/feedparser/RSSFeedParser.java URL: http://svn.apache.org/viewcvs/jakarta/commons/dormant/feedparser/trunk/src/java/org/apache/commons/feedparser/RSSFeedParser.java?rev=373612&r1=373611&r2=373612&view=diff ============================================================================== --- jakarta/commons/dormant/feedparser/trunk/src/java/org/apache/commons/feedparser/RSSFeedParser.java (original) +++ jakarta/commons/dormant/feedparser/trunk/src/java/org/apache/commons/feedparser/RSSFeedParser.java Mon Jan 30 14:27:44 2006 @@ -297,7 +297,9 @@ String type = element.getAttributeValue( "type" ); String href = element.getAttributeValue( "url" ); String title = null; - long length = Integer.parseInt( element.getAttributeValue( "length" ) ); + long length = 0; + if (element.getAttributeValue("length") != null) + length = Integer.parseInt( element.getAttributeValue( "length" ) ); linkFeedParserListener.onLink( state, rel, --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org