Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 90631 invoked from network); 19 Jan 2006 21:47:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Jan 2006 21:47:08 -0000 Received: (qmail 94045 invoked by uid 500); 19 Jan 2006 21:47:07 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 93538 invoked by uid 500); 19 Jan 2006 21:47:04 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 93524 invoked by uid 99); 19 Jan 2006 21:47:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2006 13:47:04 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of joerg.schaible@gmx.de designates 213.165.64.21 as permitted sender) Received: from [213.165.64.21] (HELO mail.gmx.net) (213.165.64.21) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 19 Jan 2006 13:47:04 -0800 Received: (qmail invoked by alias); 19 Jan 2006 21:46:42 -0000 Received: from p549A8396.dip0.t-ipconnect.de (EHLO paddy.schaible.local) [84.154.131.150] by mail.gmx.net (mp027) with SMTP; 19 Jan 2006 22:46:42 +0100 X-Authenticated: #348333 From: =?iso-8859-1?q?J=F6rg_Schaible?= Organization: N/A To: Jakarta Commons Developers List Subject: Re: [logging] Bug 38174 and JCL 1.1 Date: Thu, 19 Jan 2006 22:46:40 +0100 User-Agent: KMail/1.8.3 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200601192246.40877.joerg.schaible@gmx.de> X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Boris Unckel wrote: > Hello Robert, >=20 > robert burrell donkin wrote: >> i'm going through the patches (by hand) now. >> >> i notice that a lot of the parameters are now declared final (which is - >> usually - good). i would have expected that this should not effect >> binary compatibility but unfortunately, i can't find anywhere in the JLS >> where this is definitely specified. i'm very reluctant to add any >> changes which risk (at all) binary compatibility issues. >> >> anyone know of a definitive reference? >=20 > First my apologies to not mention it in the patch description - I am used > to final the parameters, so I did not recognize it actively. > I cannot cite a spec or a similiar document. After your mail I just used > JAD to decompile a class again. > The final before the parameters is not part of the decompiled class. >=20 > I know that this is not a proove, but a hint. > If this is going to be a show stopper, the final should be removed. It has no effect on the binary output, otherwise you could not overwrite=20 methods and change this modifier for the parameters. For parameters it is=20 just a hint for the compiler and prevents accidental assignment. =2D J=F6rg --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org