Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 39930 invoked from network); 18 Jan 2006 04:18:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Jan 2006 04:18:51 -0000 Received: (qmail 12188 invoked by uid 500); 18 Jan 2006 04:18:48 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 12155 invoked by uid 500); 18 Jan 2006 04:18:48 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 12144 invoked by uid 99); 18 Jan 2006 04:18:48 -0000 X-ASF-Spam-Status: No, hits=0.6 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2006 20:18:47 -0800 Received: by ajax.apache.org (Postfix, from userid 99) id 783B4E1; Wed, 18 Jan 2006 05:18:25 +0100 (CET) From: bugzilla@apache.org To: commons-dev@jakarta.apache.org Subject: DO NOT REPLY [Bug 38026] - [logging] LogFactory is not thread-safe In-Reply-To: X-Bugzilla-Reason: AssignedTo Message-Id: <20060118041825.783B4E1@ajax.apache.org> Date: Wed, 18 Jan 2006 05:18:25 +0100 (CET) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38026 ------- Additional Comments From skitching@apache.org 2006-01-18 05:18 ------- I don't believe this issue is valid. The Hashtable javadoc specifies that this class is internally synchronized (ie already thread-safe) which will prevent race conditions between concurrent calls to get/put. There is potentially an issue with the removeAll method, as a ConcurrentModificationException could occur if one thread is in removeAll while another is adding an entry to the table. However removeAll should only ever be called by the container during container shutdown so this is not expected to ever be possible in practice. Adding synchronisation everywhere just to avoid a theoretical conflict with removeAll isn't a good idea; that's a significant performance hit. If I've got this wrong, please let me know. Otherwise I will close this issue in a couple of days. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org