commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <scolebou...@btopenworld.com>
Subject Re: [id] Review before 1.0 (Summary)
Date Sat, 14 Jan 2006 16:45:31 GMT
Tim OBrien wrote:
> --- Jörg Schaible <joerg.schaible@gmx.de> wrote:
>>4/ Copied c-codec classes in official API
>>
>>To remove a dependency to c-codec the digest and hex utilities have been
>>copied to c-id, but they are now publicly available in the o.a.c.id
>>namespace.
>>
>>Martin already proposed to move them to a package o.a.c.id.internal and
>>provide an appropriate package.html. As alternative we could try to make
>>them package accessible only and remove any unused functionality (they have
>>bad coverage reports because we only use view methods).
> 
> 
> +1 with moving into an internal package with a package.html,  

I strongly prefer using package scope if at all possible, and 
referencing the svn revision id that the code was copied from.

Stephen

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message